Skip to content

Convolution backwards v4r1#4928

Draft
pfultz2 wants to merge 2 commits into
developfrom
conv-backwards-v4r1
Draft

Convolution backwards v4r1#4928
pfultz2 wants to merge 2 commits into
developfrom
conv-backwards-v4r1

Conversation

@pfultz2
Copy link
Copy Markdown
Collaborator

@pfultz2 pfultz2 commented Jun 1, 2026

Motivation

Technical Details

Rewrite convolution_backwards to match the v4r1 algorithm used in miopen.

Changelog Category

Add a CHANGELOG.md entry for any option other than Not Applicable

    • Added: New functionality.
    • Changed: Changes to existing functionality.
    • Removed: Functionality or support that has been removed. (Compared to a previous release)
    • Optimized: Component performance that has been optimized or improved.
    • Resolved Issues: Known issues from a previous version that have been resolved.
    • Not Applicable: This PR is not to be included in the changelog.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

❌ Patch coverage is 79.21348% with 37 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/rewrite_convolution.cpp 79.10% 37 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4928      +/-   ##
===========================================
- Coverage    92.66%   92.58%   -0.08%     
===========================================
  Files          588      590       +2     
  Lines        30397    30575     +178     
===========================================
+ Hits         28165    28306     +141     
- Misses        2232     2269      +37     
Files with missing lines Coverage Δ
src/include/migraphx/rewrite_convolution.hpp 100.00% <100.00%> (ø)
src/rewrite_convolution.cpp 79.10% <79.10%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant