Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include <test.hpp> | ||
|
|
||
| static void run_pass(migraphx::module& m, migraphx::fast_mm fmm = {}) | ||
| { migraphx::run_passes(m, {fmm, migraphx::dead_code_elimination{}}); } |
Contributor
There was a problem hiding this comment.
[format.py] reported by reviewdog 🐶
Suggested change
| { migraphx::run_passes(m, {fmm, migraphx::dead_code_elimination{}}); } | |
| { | |
| migraphx::run_passes(m, {fmm, migraphx::dead_code_elimination{}}); | |
| } |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4895 +/- ##
========================================
Coverage 92.66% 92.66%
========================================
Files 588 590 +2
Lines 30397 30444 +47
========================================
+ Hits 28165 28210 +45
- Misses 2232 2234 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since navi doesnt have fp32 wmmas, we can use fp16 instead to get better performance.
Technical Details
This only converts the wmma to fp16 but still outputs fp32. To improve accuracy beyond just vanilla fp16 it extends the weights with residuals.
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable