Skip to content

Changed the maximum and minimum steering angles - #7

Merged
Geonhee-LEE merged 5 commits into
mainfrom
feature-steering-max-degree
Apr 17, 2026
Merged

Changed the maximum and minimum steering angles#7
Geonhee-LEE merged 5 commits into
mainfrom
feature-steering-max-degree

Conversation

@Geonhee-LEE

Copy link
Copy Markdown
Contributor
  • Changed maximum/minimum steering angle limitation based on physical constraints

dujeong and others added 4 commits April 17, 2026 09:30
Signed-off-by: Daun Jeong <jdu@robotis.com>
Signed-off-by: Geonhee-LEE <lgh@robotis.com>
Signed-off-by: Geonhee-LEE <lgh@robotis.com>
@Geonhee-LEE
Geonhee-LEE requested a review from dujeong April 17, 2026 00:43

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the steering limits for the Antbot across several configuration files, reducing the maximum steering angle from approximately 56 degrees to 55 degrees (0.959 radians). A minor formatting inconsistency was identified in the swerve drive controller configuration where extra spacing was used in one of the array definitions.

Comment thread antbot_swerve_controller/config/swerve_drive_controller.yaml Outdated

@dujeong dujeong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Signed-off-by: Geonhee-LEE <lgh@robotis.com>
@Geonhee-LEE
Geonhee-LEE merged commit 4e31757 into main Apr 17, 2026
10 of 11 checks passed
@Geonhee-LEE
Geonhee-LEE deleted the feature-steering-max-degree branch April 17, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants