fix(ci): gofmt internal/mcp/codegen.go (un-break main)#89
Merged
Conversation
The #4 sed-based removal of the `sort` import / Discover left a trailing blank line at EOF, which the CI golangci-lint lane (full-repo gofmt) flagged on the #88 merge commit. My local lint runs had only targeted specific packages (not ./internal/mcp after that edit) and `make verify` doesn't run gofmt, so it slipped through. Verified with the EXACT CI command: `golangci-lint run` (full repo, clean cache, v2.12.2) → 0 issues; gofmt -l clean; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #88 merge commit went red on the golangci-lint lane only (the other 5 — make verify, tui-verify, -race, sandbox-linux, browser — passed):
internal/mcp/codegen.go:43:1: File is not properly formatted (gofmt). A trailing blank line at EOF left by the #4sedremoval of thesortimport. My local lint had only targeted specific packages (not./internal/mcpafter that edit) andmake verifydoesn't run gofmt.Fix = remove the trailing blank line. Verified with the exact CI command (
golangci-lint run, full repo, clean cache, v2.12.2) → 0 issues;gofmt -lclean; build green.🤖 Generated with Claude Code