Adding Hoops support to RLViserRenderer and RocketSimEngine#89
Open
bpblakely wants to merge 2 commits into
Open
Adding Hoops support to RLViserRenderer and RocketSimEngine#89bpblakely wants to merge 2 commits into
bpblakely wants to merge 2 commits into
Conversation
… other game modes. Hoops boost locations taken directly from rocketsim source code https://github.com/ZealanL/RocketSim/blob/972dc093058efa50e153f64381b68678ad78baee/src/RLConst.h#L355
…ependant, only supporting soccar and hoops currently. Hoops goal check is taken from rocketsim code here https://github.com/ZealanL/RocketSim/blob/972dc093058efa50e153f64381b68678ad78baee/src/Sim/Arena/Arena.cpp#L760
lucas-emery
reviewed
May 16, 2026
|
|
||
| # Only works for soccar | ||
| gs.goal_scored = abs(gs.ball.position[1]) > GOAL_THRESHOLD | ||
| gs.goal_scored = self._get_goal_scored(gs.ball.position) |
Member
There was a problem hiding this comment.
Can't we get this from rsim instead? I remember there where some callbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RLViserRenderer is updated to allow hoops to be visualized. Boost locations taken from Rocket Sim
Updated the goal checking logic in RocketSimEngine to support hoops. Logic and constants taken from Rocket Sim