Skip to content

Revert "Merge #116" - #220

Merged
bors[bot] merged 1 commit into
RIOT-OS:masterfrom
kaspar030:revert_116
Dec 19, 2022
Merged

Revert "Merge #116"#220
bors[bot] merged 1 commit into
RIOT-OS:masterfrom
kaspar030:revert_116

Conversation

@kaspar030

Copy link
Copy Markdown
Contributor

It pains me a lot but the bad debian newlib package won't be fixed in time for the hard freeze, and neither will we sort out the issues with picolibc as default, in the week before x-mas. :(

This reverts commit 20529a8 (#116), reversing changes made to 604bc23.

This reverts commit 20529a8, reversing
changes made to 604bc23.
@aabadie

aabadie commented Dec 19, 2022

Copy link
Copy Markdown
Contributor

I would prefer to only revert the commits related to #116, e.g c49165b, dc6e40f, 1afc188 and 1d52cae

@aabadie

aabadie commented Dec 19, 2022

Copy link
Copy Markdown
Contributor

Hmm, this PR does this (same diff), so OK :)

@kaspar030

kaspar030 commented Dec 19, 2022

Copy link
Copy Markdown
Contributor Author

I would prefer to only revert the commits related to #116, e.g c49165b, dc6e40f, 1afc188 and 1d52cae

This is git revert -m1 20529a8aa6996c784e2ca2921e1356ee1fcdd5ee, then manually fixing a conflict in the packages.
What else did get removed? Was it the installation of the c++ packages?

edit simultaneous typing

@aabadie

aabadie commented Dec 19, 2022

Copy link
Copy Markdown
Contributor

Could you test locally if that fixes the size increase ? (I'm still building the Docker image...)

@aabadie aabadie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and I confirm that the Docker images generated with the changes in this PR fixes the code size increase.

ACK

@aabadie

aabadie commented Dec 19, 2022

Copy link
Copy Markdown
Contributor

bors merge

@bors

bors Bot commented Dec 19, 2022

Copy link
Copy Markdown
Contributor

Build succeeded:

  • Build and Test

@bors
bors Bot merged commit 5efc102 into RIOT-OS:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants