dist/tools/buildsys_sanity_check: use release version for Docker check - #22593
Open
crasbe wants to merge 1 commit into
Open
dist/tools/buildsys_sanity_check: use release version for Docker check#22593crasbe wants to merge 1 commit into
crasbe wants to merge 1 commit into
Conversation
crasbe
force-pushed
the
pr/docker_release_version_check
branch
from
August 18, 2026 11:10
84c3b6e to
2f99df8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Currently, the docker image version is static and is not updated when a release happens.
If the Docker container is updated in the meantime, no backports to the release branch are possible anymore because the static test fails.
Therefore, I extended the buildsystem sanity check to check if a
VERSIONfile is present inRIOTBASEand if it is, the version string from that file is used to fetch the hash fromdocker.ioto compare to theDOCKER_TESTED_IMAGE_REPO_DIGESTvariable inmakefiles/docker.inc.mkinstead of getting thelatesthash.Testing procedure
The test should still succeed on
master:The test should also succeed on a release branch. In our current situation, this will only work on the
2026.07-branchbecause the Docker image happens to be at2026.07and hasn't been updated as thoroughly as it should've been before.This has been addressed in the release guides though in #22214, however I might have to extend the documentation there a little bit as well as in the docker container itself.
(Added blank lines to the logs to make it easier to read).
Issues/PRs references
Required for RIOT-OS/riotdocker#64 and RIOT-OS/riotdocker#287
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: