pkg/qcbor: disable HW FPU support for ESP32S2&ESP8266 - #22179
Merged
Conversation
crasbe
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
April 8, 2026 00:34
In some newlib implementations of the ESP toolchain, the `feclearexcept` and `fetestexcept` functions are not implemented. Converting a float to UINT64 explicitly triggers these functions, enabling us to check if the exception condition in the package Makefile still works as intended.
maribu
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The newlib implementation of some ESP variants does not implement the
feclearexceptandfetestexceptfunctions fromfenv.hused byQCBOR. Disabling the HW FPU support works around this issue.
Testing procedure
I added a test case in the
qcbortest. Comment out theCFLAGSline and the compilation will fail, with the line commented in it will succeed.Commented out:
Commented in:
Issues/PRs references
Discovered while building the
Makefile.cifor #22091.Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: