riotctrl_shell: add ShellInteraction for congure_test - #16119
Merged
Conversation
miri64
added
Type: enhancement
miri64
requested review from
MichelRottleuthner,
kaspar030,
leandrolanzieri and
smlng
as code owners
March 2, 2021 08:57
This was referenced Mar 2, 2021
miri64
added
the
CI: ready for build
miri64
force-pushed
the
riotctrl_shell/feat/congure_test
branch
from
March 3, 2021 11:40
05f08fc to
b34aa79
Compare
Member
Author
|
Rebased to current master and dependencies to resolve merge conflict. |
miri64
force-pushed
the
riotctrl_shell/feat/congure_test
branch
from
March 3, 2021 13:13
b34aa79 to
0d310bd
Compare
Member
Author
|
Rebased to current master since #16111 was merged. |
kaspar030
reviewed
Mar 9, 2021
Contributor
|
LGTM, please squash! feel free to add the "BOARD" thingy. I tested this on nrf52840dk, CI tested wroom32 and samr21-xpro. As other tests are probably using the changed riotctrl_shell, I suggest giving this a full test run. |
Member
Author
There is currently only |
miri64
force-pushed
the
riotctrl_shell/feat/congure_test
branch
from
March 9, 2021 10:24
0d310bd to
5ceffde
Compare
Member
Author
|
Squashed the provided doc improvement suggestion and removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This introduces a shell interaction for the shell commands of
congure_test.Testing procedure
I added tests both in
dist/pythonlibs/riotctrl_shell/tests(unittests) andtests/congure_test(integration tests), both tests should still pass:Issues/PRs references
Requires
#16111 as it rewrote some of the shell commands for(merged).congure_test