print_toolchain_versions: print system and make's default shell. - #13038
Merged
Conversation
smlng
added
Area: build system
Member
Author
|
btw. authorship of @jcarrano is retained |
fjmolinas
approved these changes
Jan 7, 2020
fjmolinas
left a comment
fjmolinas
left a comment
Contributor
There was a problem hiding this comment.
The original PR had already been reviewed in detail, tested on ubuntu:
Operating System Environment
-----------------------------
Operating System: "Ubuntu" "18.04.2 LTS (Bionic Beaver)"
Kernel: Linux 5.0.0-37-generic x86_64 x86_64
System shell: /bin/dash (probably dash)
make's shell: /bin/dash (probably dash)
It was tested on mac on #10991. I have a minor comment regarding a change with respect to the original PR. I won't insist on it though. If you address it then squash immediately. Otherwise ACK (merge if you will not.)
| printf "%25s: %s\n" "Operating System" "$(get_os_info)" | ||
| printf "%25s: %s\n" "Kernel" "$(get_kernel_info)" | ||
| printf "%25s: %s\n" "System shell" "$(get_sys_shell)" | ||
| printf "%25s: %s\n" "make's shell" "$(get_make_shell)" |
Contributor
There was a problem hiding this comment.
I think the original was more accurate since get_make_shell is actually getting the value of makes SHELL variable. I would prefer it that way but wont insist.
Suggested change
| printf "%25s: %s\n" "make's shell" "$(get_make_shell)" | |
| printf "%25s: %s\n" "make's SHELL" "$(get_make_shell)" |
Member
Author
There was a problem hiding this comment.
ok, makes sense - reverted and amended directly. Still works on macOS btw
Some systems use dash as system shell, others use bash. The shell used by make can also be different, and unrelated to the system shell. Differences in this variable can cause problems when testing PRs and reporting bugs. The default shell is important system information that should be reported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Overtook #10991 to fix conflicts as authors is not available (anymore).
Some systems use dash as system shell, others use bash. The shell used
by make can also be different, and unrelated to the system shell.
Differences in this variable can cause problems when testing PRs and
reporting bugs.
The default shell is important system information that should be reported.
Testing procedure
run
./dist/tools/ci/print_toolchain_versions.shfrom RIOTBASE on your system - and if you like report the output here.Issues/PRs references