Skip to content

tests: add distinct test app for nrfmin driver - #12314

Merged
miri64 merged 1 commit into
RIOT-OS:masterfrom
haukepetersen:add_test_nrfmin
Sep 27, 2019
Merged

tests: add distinct test app for nrfmin driver#12314
miri64 merged 1 commit into
RIOT-OS:masterfrom
haukepetersen:add_test_nrfmin

Conversation

@haukepetersen

Copy link
Copy Markdown
Contributor

Contribution description

At the moment, we make nrfmin as default netif interface for some randomly selected nrf52-based platforms (e.g. ruuvitag). I think it would be much better to be consistent and have the same default interfaces for all platforms using the same CPU:

  • nrf51, nrf52832 -> nimble_netif
  • nrf52840 -> ´nrf802154`

But if we would apply that mapping right now (see also discussion in #11792), nrfmin would be dropped from our testing. So this PR adds a dedicated test application for this driver to make sure this doesn't happen.

Testing procedure

Run make test for any nrf-based board, it should always work :-)

Issues/PRs references

#11792 does some dependency cleanup for nrf52-based boards. With this the generic structure can even be more simplified.

@haukepetersen haukepetersen added Area: tests Area: tests and testing framework Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 27, 2019
@miri64 miri64 added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 27, 2019

@miri64 miri64 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, introducing a separate test is sensible. The test should be run properly by Murdock on nrf52dk.

@miri64 miri64 added this to the Release 2019.10 milestone Sep 27, 2019
@miri64
miri64 merged commit aa7f23d into RIOT-OS:master Sep 27, 2019
@miri64

miri64 commented Sep 27, 2019

Copy link
Copy Markdown
Member

(tests were run on Murdock:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants