Skip to content

cpu/nrf5x: decelare radio_nrfble feat for all nrfs - #12313

Merged
benpicco merged 1 commit into
RIOT-OS:masterfrom
haukepetersen:fix_nrfble_featuredecl
Sep 27, 2019
Merged

cpu/nrf5x: decelare radio_nrfble feat for all nrfs#12313
benpicco merged 1 commit into
RIOT-OS:masterfrom
haukepetersen:fix_nrfble_featuredecl

Conversation

@haukepetersen

Copy link
Copy Markdown
Contributor

Contribution description

The nrfble driver is working for all nrf-based CPUs (nrf51 and nrf52x), but the radio_nrfble feature is right now only and weirdly declared in boards/common/nrf52/Makefile.features. So the clean way would obviously be to declare that feature in cpu/nrf5x_common/Makefile.features, same as already done for radio_nrfmin.

Besides the structural cleanup, this change does furthermore enable skald to be build on nrf51-based platforms. This is intended and works as expected.

Testing procedure

make buildtest for examples/skald_x should build all boards that were build before, and also for all nrf51-based ones.

Further, at least one nrf51-based board should be flashed with a skald example and its behavior should should be verified with any BLE scanner (e.g. use your phone or examples/nimble_scanner on any nrf52-based board).

Issues/PRs references

none

@haukepetersen haukepetersen added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: BLE Area: Bluetooth Low Energy support labels Sep 27, 2019
@benpicco

Copy link
Copy Markdown
Contributor

What about ble_nimble, is that specific to nrf52?

@haukepetersen

Copy link
Copy Markdown
Contributor Author

Yes, at the moment it is, as there are some side effects to take into account when running nimble on the nrf51s. But I will look into this in a separate PR.

@haukepetersen

Copy link
Copy Markdown
Contributor Author

The ble_nimble thins is also partly related to the cleanup in #11792

@benpicco benpicco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then this is pretty straightforward.
Minor change, no regressions.

@benpicco
benpicco merged commit 3a32679 into RIOT-OS:master Sep 27, 2019
@haukepetersen

Copy link
Copy Markdown
Contributor Author

thanks for the quick review!

@haukepetersen
haukepetersen deleted the fix_nrfble_featuredecl branch September 27, 2019 09:20
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: BLE Area: Bluetooth Low Energy support CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants