cpu/nrf5x: decelare radio_nrfble feat for all nrfs - #12313
Merged
Conversation
Contributor
|
What about |
Contributor
Author
|
Yes, at the moment it is, as there are some side effects to take into account when running nimble on the nrf51s. But I will look into this in a separate PR. |
Contributor
Author
|
The |
benpicco
approved these changes
Sep 27, 2019
benpicco
left a comment
Contributor
There was a problem hiding this comment.
Ok, then this is pretty straightforward.
Minor change, no regressions.
Contributor
Author
|
thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The
nrfbledriver is working for all nrf-based CPUs (nrf51 and nrf52x), but theradio_nrfblefeature is right now only and weirdly declared inboards/common/nrf52/Makefile.features. So the clean way would obviously be to declare that feature incpu/nrf5x_common/Makefile.features, same as already done forradio_nrfmin.Besides the structural cleanup, this change does furthermore enable
skaldto be build onnrf51-based platforms. This is intended and works as expected.Testing procedure
make buildtestforexamples/skald_xshould build all boards that were build before, and also for allnrf51-based ones.Further, at least one
nrf51-based board should be flashed with askaldexample and its behavior should should be verified with any BLE scanner (e.g. use your phone orexamples/nimble_scanneron anynrf52-based board).Issues/PRs references
none