Skip to content

cpu/saml1x: update periph status implementation in board doc.txt - #11892

Merged
benpicco merged 2 commits into
RIOT-OS:masterfrom
Einhornhool:saml1x-doc-update
Aug 8, 2019
Merged

cpu/saml1x: update periph status implementation in board doc.txt#11892
benpicco merged 2 commits into
RIOT-OS:masterfrom
Einhornhool:saml1x-doc-update

Conversation

@Einhornhool

Copy link
Copy Markdown
Contributor

Contribution description

Updated the implementation status of the boards saml10-xpro and saml11-xpro.
Before only support of low-level drivers GPIO, UART and Timer was documented.
Testing showed that I2C, SPI, RTT, RTC, RNG and ADC also work on both boards.

Testing procedure

I ran the following tests:
periph_i2c
periph_spi
periph_rtt
periph_rtc
periph_adc
rng

@dylad dylad added Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 24, 2019
@dylad dylad added this to the Release 2019.10 milestone Jul 24, 2019
@dylad dylad changed the title Saml1x update status implementation in documentary cpu/saml1x: update periph status implementation in board doc.txt Jul 24, 2019
Comment thread boards/saml10-xpro/doc.txt
@PeterKietzmann

PeterKietzmann commented Jul 25, 2019

Copy link
Copy Markdown
Member

I just ran tests/periph_adc on a saml11-xpro which works somehow but I think something might be messed up in the peripheral driver implementation. In main.c we sample with 10 bit but the test prints values between ~ 96 ... 65520 for ~0...3.3V which shouldn't be possible at 10 bit right? @dylad any ideas?

@dylad

dylad commented Jul 25, 2019

Copy link
Copy Markdown
Member

I'll take a closer look at it next week.

@dylad

dylad commented Aug 2, 2019

Copy link
Copy Markdown
Member

@dylad any ideas?

I have one. I'll submit a PR soon so you can fully test it.
Thanks for spotting this @PeterKietzmann !

@dylad

dylad commented Aug 2, 2019

Copy link
Copy Markdown
Member

@Einhornhool regarding this PR, do you want to wait for #11647 to be merge first so we can merge this one or you can remove hwrng support from the list and we can merge it right now.

@Einhornhool

Copy link
Copy Markdown
Contributor Author

@dylad
I just took a look at that pr. Isn't it already merged?
I can still remove rng support, if you're not sure it works.

Thank you for working on this =)

@PeterKietzmann

Copy link
Copy Markdown
Member

Yeah it's been merged in the meantime, no need to remove RNG support - it's been tested. However, there are open issues with the ADC implementation. @dylad any news on that?

Comment thread boards/saml11-xpro/doc.txt Outdated
@dylad

dylad commented Aug 6, 2019

Copy link
Copy Markdown
Member

@PeterKietzmann #11972 should fixes your issue, I have limited access to my hardware because I'm moving so I cannot fully test it right now.

@PeterKietzmann

Copy link
Copy Markdown
Member

ADC's are fine with #11972. @Einhornhool please adopt @benpicco's comment. We are ready to merge afterwards.

@Einhornhool

Copy link
Copy Markdown
Contributor Author

@PeterKietzmann Thanks, will do. Guess I made a mistake there.

@benpicco

benpicco commented Aug 8, 2019

Copy link
Copy Markdown
Contributor

I'd say you can squash right away.

Lena Boeckmann and others added 2 commits August 8, 2019 14:49
@Einhornhool

Copy link
Copy Markdown
Contributor Author

@benpicco done

@benpicco benpicco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments addressed, so this is good to go!

@benpicco
benpicco merged commit 09298c0 into RIOT-OS:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants