Skip to content

C2po develop#52

Open
cgjohannsen wants to merge 82 commits into
developfrom
c2po-develop
Open

C2po develop#52
cgjohannsen wants to merge 82 commits into
developfrom
c2po-develop

Conversation

@cgjohannsen

Copy link
Copy Markdown
Contributor

Major rewrite of c2po, adding REPL capability. Allows for granular control of the compiler and extra analysis.

aaurandt and others added 30 commits July 1, 2025 16:19
Adds previous functionality and subsequently removes rate since rate had undefined behavior at i=0 (i.e., there was no i=-1 to accurately calculate rate with)
…tl patterns benchmarks, major updates to eqsat.
@cgjohannsen cgjohannsen requested a review from aaurandt April 15, 2026 16:49
@cgjohannsen cgjohannsen self-assigned this Apr 15, 2026

@aaurandt aaurandt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing obvious sticks out other than the few minor changes required when computing the minimal bounds. I will try to pull and play with these changes to C2PO early next week, and provide further feedback.

Comment thread compiler/c2po/assemble.py Outdated
Comment thread compiler/c2po/assemble.py Outdated
Comment thread compiler/c2po/assemble.py Outdated
Comment thread compiler/c2po/assemble.py Outdated
Comment thread compiler/c2po/assemble.py Outdated
cgjohannsen and others added 2 commits May 21, 2026 16:26
Co-authored-by: Alexis Aurandt <lexaurandt@gmail.com>
@aaurandt

aaurandt commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

I find it a little annoying that we now have to specify --spec to input the spec into C2PO. Is there ever an option where we won't be providing a .c2po file as input into C2PO?

I fixed some problems with check-sat. Should we add a few tests for this? Also, should there be something printed to the console when enabling SAT checking? If I recall correctly, there was previously a message printed indicating the results.

I also fixed some other option errors. I think I fixed them all, but you may want to double check.

@cgjohannsen Will we release this as 4.2.0? If so, I can update the version numbers in C2PO/R2U2.

@cgjohannsen

Copy link
Copy Markdown
Contributor Author

The issue with omitting the '--spec' option is that when c2po runs in interactive or script mode it doesn't take as .c2po file as input. So 'python3 c2po.py -i' launches into interactive mode and shouldn't take any file as input. Same for when proving a script as in 'python3 c2po.py -s script.cmd'.

As for sat checking messaging, the check_sat command has a '--print' option that will print the output but it's off by default. I figure the best behavior is to only warn the user when their spec is unsat or unknown.

And I say we do a minor version bump like you suggest, so to 4.2.0.

Thanks for the help on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants