NC34 compat: create stable34 branch and pin to Nextcloud 34#381
Draft
Copilot wants to merge 2 commits into
Draft
NC34 compat: create stable34 branch and pin to Nextcloud 34#381Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/R0Wi-DEV/workflow_ocr/sessions/048d7183-9f88-4253-b110-2c899f48ac91 Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com>
Contributor
|
@copilot https://github.com/R0Wi-DEV/workflow_ocr/actions/runs/26150407332/job/76980726462?pr=381 failed, bump composer deps |
Agent-Logs-Url: https://github.com/R0Wi-DEV/workflow_ocr/sessions/0009e1ac-95a1-446e-a50a-8f334a700d1d Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com>
Contributor
Author
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins the
workflow_ocrapp to Nextcloud 34 by updating all CI workflow files, composer.json, and documentation. This fixes the failing CI run (https://github.com/R0Wi-DEV/workflow_ocr/actions/runs/25953887751) which failed becauseappinfo/info.xmlspecifiedmax-version="34"but the CI was testing against Nextcloud master (NC35).This follows the same pattern used for the NC33 compat commit (#350).
Changes
.github/workflows/phpunit.yml:server-versions: ['master']→['stable34'](all 3 matrix jobs: sqlite, mysql, pgsql).github/workflows/phpunit-integration.yml:server-versions: ['master']→['stable34'].github/workflows/psalm.yml:ocp-version: ['dev-master']→['dev-stable34'].github/workflows/sonarqube.yml:server-versions: ['master']→['stable34']composer.json:nextcloud/ocp: dev-master→dev-stable34.github/copilot-instructions.md: Update current NC target version to 34Note:
appinfo/info.xmlalready hasmin-version="34" max-version="34"andREADME.mdalready has the NC34 badge — those were set in a previous commit.