Fix order-dependent ASOIAF test skipping data() load before exists() check - #164
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix code as per review comment 3660917598
Fix order-dependent ASOIAF test skipping data() load before exists() check
Jul 27, 2026
Fix order-dependent ASOIAF test: move data() call before exists() check
smasongarrison
force-pushed
the
copilot/fix-review-comment-3660917598
branch
from
July 27, 2026 21:24
2aeb66b to
c402f2b
Compare
smasongarrison
marked this pull request as ready for review
July 27, 2026 21:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ASOIAF test at line 415 of
test-kinship2_aligns.Rcheckedexists("ASOIAF")before callingdata("ASOIAF"), so the test would silently skip when run in isolation or out of order — only passing when an earlier test had already loaded the dataset into the environment.Change
tests/testthat/test-kinship2_aligns.R: Moveddata("ASOIAF")to before theexists()/nrow()guard in the"classic option passes through kinship2_alignped stages with ASOIAF"test, matching the pattern already used by all other ASOIAF tests in the same file.Before:
After: