Fix profile ARN resolution before account refresh calls#113
Open
STA1N156 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This resolves the account profile ARN before calling REST endpoints that require it, including
getUsageLimitsandListAvailableModels.Why
Some refreshed credentials return a valid access token but do not include
profileArnin the refresh response. The streaming path already resolves the profile ARN before sending messages, but the REST refresh/model-list paths could call AWS without it and receive:HTTP 403: {"message":"User is not authorized to make this call.","reason":null}That can make a healthy account look unauthorized during admin refresh/model refresh.
Validation
profileArn.getUsageLimitsandListAvailableModelsreturn 403 withoutprofileArn.profileArn.