Conversation
Signed-off-by: Quntized <mdsajid-09-2021911491@ne.du.ac.bd>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to adjust the standalone kokkos_tree test harness to support CUDA-related functionality and add a regression test around desul atomics/numeric-limits behavior.
Changes:
- Add a CUDA-related header include to the
Kokkos_qun_testtest driver. - Add a new
desulunit test validating numeric limits/type traits. - Update the test executable link line to include an additional Kokkos CMake target.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
kokkos_tree/test_dyn_rank.cpp |
Adds a CUDA-related header include to the test runner TU. |
kokkos_tree/desul/desul_test.hpp |
Adds a new gtest covering desul::Impl::numeric_limits_max and related types. |
kokkos_tree/CMakeLists.txt |
Extends link libraries for Kokkos_qun_test with Kokkos::kokkoscore. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
3
to
6
| #include "mdspan/kokkos_raw_mdspan.hpp" | ||
| #include "kokkos_core/test_drank.hpp" | ||
| #include "kokkos_core/cuda_Error.hpp" | ||
| #include <Kokkos_Core.hpp> |
Comment on lines
+65
to
+75
| TEST(DesulNumericLimitsTest,atomics_include_desul_atomics_Common_hpp_L82 ){ | ||
| constexpr uint32_t desul_max = desul::Impl::numeric_limits_max<uint32_t>::value; | ||
| constexpr uint32_t std_max = std::numeric_limits<uint32_t>::max(); | ||
| EXPECT_EQ(desul_max, std_max) << "Doesn't match"; | ||
| constexpr uint64_t desul_max64 = desul::Impl::numeric_limits_max<uint64_t>::value; | ||
| constexpr uint64_t std_max64 = std::numeric_limits<uint64_t>::max(); | ||
| EXPECT_EQ(desul_max64, std_max64) << "Doesn't match"; | ||
| auto val = sizeof(int64_t); | ||
| EXPECT_EQ(val, 8) << "Doesn't match"; | ||
| ASSERT_TRUE((std::is_same_v<desul::Impl::atomic_compare_exchange_t<int64_t>, int64_t>)) << "Doesn't match"; | ||
| } |
Comment on lines
+66
to
+71
| constexpr uint32_t desul_max = desul::Impl::numeric_limits_max<uint32_t>::value; | ||
| constexpr uint32_t std_max = std::numeric_limits<uint32_t>::max(); | ||
| EXPECT_EQ(desul_max, std_max) << "Doesn't match"; | ||
| constexpr uint64_t desul_max64 = desul::Impl::numeric_limits_max<uint64_t>::value; | ||
| constexpr uint64_t std_max64 = std::numeric_limits<uint64_t>::max(); | ||
| EXPECT_EQ(desul_max64, std_max64) << "Doesn't match"; |
Comment on lines
11
to
13
| add_executable(Kokkos_qun_test test_dyn_rank.cpp) | ||
| target_link_libraries(Kokkos_qun_test PRIVATE Kokkos::kokkos GTest::gtest) | ||
| target_link_libraries(Kokkos_qun_test PRIVATE Kokkos::kokkos Kokkos::kokkoscore GTest::gtest) | ||
|
|
Signed-off-by: Quntized <mdsajid-09-2021911491@ne.du.ac.bd>
Quntized
marked this pull request as draft
July 19, 2026 10:27
Signed-off-by: Quntized <mdsajid-09-2021911491@ne.du.ac.bd>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.