Support prepared statements and parameters#21
Draft
vhiairrassary wants to merge 1 commit intoQuery-farm:mainfrom
Draft
Support prepared statements and parameters#21vhiairrassary wants to merge 1 commit intoQuery-farm:mainfrom
vhiairrassary wants to merge 1 commit intoQuery-farm:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I need to support untrusted inputs so I have created this PR as a starting point to see if you would be interested to have this feature merged upstream, and if yes, to discuss about the details.
How it works
How to test it
It can be tested using:
and
Questions/notes
CheckAuthenticationandExtractFormatfunctions for example). They are not on the happy path and should not impact performances (assuming the database is not publicly available, which sounds reasonable)parameter. This sounds weird and I would be happy to move all the parameters (format,query/qandparameters) inside a single JSON body. Wdyt? We could either:formatandquery/q), the POST (withformatandquery/q) and POST with a JSON body (withformatandquery/qandparameters)formatandquery/qandparameters), but it would be a breaking changeDEALLOCATEoperation)