Replace Transient state for Starting and Halting#455
Open
ben-grande wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
==========================================
- Coverage 69.40% 69.29% -0.11%
==========================================
Files 17 17
Lines 4059 4058 -1
==========================================
- Hits 2817 2812 -5
- Misses 1242 1246 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Without this PR, the application crashes when it sees a power state it is not aware of, such as Jul 16 17:06:21 dom0 python3[186072]: Traceback (most recent call last):
File "/usr/lib/python3.13/site-packages/qubesmanager/qube_manager.py", line 173, in paint
self.stateIcons[index.data()['power']].pixmap(iconSize))
~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'Starting'
Jul 16 17:06:21 dom0 systemd-coredump[187813]: [] Process 186072 (qubes-qube-mana) of user 1000 dumped core.Is a transition period necessary? Where the server sends |
ben-grande
force-pushed
the
transient
branch
2 times, most recently
from
July 16, 2026 16:16
500be91 to
b7cfaa7
Compare
ben-grande
marked this pull request as ready for review
July 23, 2026 13:25
"Transient" state will be fully deprecated on Qubes R5.0. For now, "Halting" is received but "Staring" is not received yet. For: QubesOS/qubes-issues#10966 Requires: QubesOS/qubes-core-admin-client#480
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For: QubesOS/qubes-issues#10966
Requires: QubesOS/qubes-core-admin-client#480