Lint with mypy on CI#219
Conversation
|
@nihalxkumar You modified some of these files in your PR, I think that it is easier:
Rather than fixing those errors in a separate PR, as that might cause some merge conflicts. |
|
I ran the mypy check on my branch. It reports the same 34 errors already present on main, with no new errors from my changes |
Bodies of untyped functions are not checked, so you can add return type to functions you added to make mypy lint them. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 12 12
Lines 1344 1344
=======================================
Hits 960 960
Misses 384 384 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
I'd like mypy to run on #213.