Skip to content

Lint with mypy on CI#219

Open
ben-grande wants to merge 2 commits into
QubesOS:mainfrom
ben-grande:mypy
Open

Lint with mypy on CI#219
ben-grande wants to merge 2 commits into
QubesOS:mainfrom
ben-grande:mypy

Conversation

@ben-grande

Copy link
Copy Markdown
Contributor

I'd like mypy to run on #213.

@ben-grande
ben-grande marked this pull request as draft July 24, 2026 09:05
@ben-grande

Copy link
Copy Markdown
Contributor Author

@nihalxkumar You modified some of these files in your PR, I think that it is easier:

  • We enable CI in your PR
  • You check what new issues were introduced and fix them in the same PR

Rather than fixing those errors in a separate PR, as that might cause some merge conflicts.

@nihalxkumar

Copy link
Copy Markdown
Contributor

I ran the mypy check on my branch. It reports the same 34 errors already present on main, with no new errors from my changes
I think we should use #219 to fix the baseline errors before this CI job is brought into qvm-template-upgrade branch

@ben-grande
ben-grande marked this pull request as ready for review July 27, 2026 10:52
@ben-grande

Copy link
Copy Markdown
Contributor Author

with no new errors from my changes

Bodies of untyped functions are not checked, so you can add return type to functions you added to make mypy lint them.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.42%. Comparing base (4973653) to head (01027e3).

Files with missing lines Patch % Lines
vmupdate/update_manager.py 57.14% 6 Missing ⚠️
vmupdate/agent/source/common/process_result.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   71.42%   71.42%           
=======================================
  Files          12       12           
  Lines        1344     1344           
=======================================
  Hits          960      960           
  Misses        384      384           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants