Conversation
There was a problem hiding this comment.
Code Review
This pull request updates src/CQtDeployer/CMakeLists.txt to copy the installerbase executable from the Qt Installer Framework to the build directory. The review feedback recommends renaming the newly introduced variables with the ambiguous _B suffix to more descriptive names, such as QIF_SOURCE_BASE_PATH and QIF_OUT_BASE_PATH, to improve code readability and maintainability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| set(QIF_SOURCE_BIN_PATH_B "${IQTA_TOOLS}/QtInstallerFramework/${QIFW_VERSION}/bin/installerbase.exe") | ||
| set(QIF_OUT_BIN_PATH_B "${QIF_DESTINATION_PATH}/installerbase.exe") |
There was a problem hiding this comment.
The variable suffix _B is ambiguous and does not clearly indicate that it refers to installerbase. Consider renaming QIF_SOURCE_BIN_PATH_B and QIF_OUT_BIN_PATH_B to QIF_SOURCE_BASE_PATH and QIF_OUT_BASE_PATH (or QIF_SOURCE_INSTALLERBASE_PATH and QIF_OUT_INSTALLERBASE_PATH) to improve readability and maintainability.
set(QIF_SOURCE_BASE_PATH "${IQTA_TOOLS}/QtInstallerFramework/${QIFW_VERSION}/bin/installerbase.exe")
set(QIF_OUT_BASE_PATH "${QIF_DESTINATION_PATH}/installerbase.exe")
| set(QIF_SOURCE_BIN_PATH_B "${IQTA_TOOLS}/QtInstallerFramework/${QIFW_VERSION}/bin/installerbase") | ||
| set(QIF_OUT_BIN_PATH_B "${QIF_DESTINATION_PATH}/installerbase") |
There was a problem hiding this comment.
Rename QIF_SOURCE_BIN_PATH_B and QIF_OUT_BIN_PATH_B to QIF_SOURCE_BASE_PATH and QIF_OUT_BASE_PATH here as well to maintain consistency and clarity.
set(QIF_SOURCE_BASE_PATH "${IQTA_TOOLS}/QtInstallerFramework/${QIFW_VERSION}/bin/installerbase")
set(QIF_OUT_BASE_PATH "${QIF_DESTINATION_PATH}/installerbase")
| COMMAND ${CMAKE_COMMAND} -E copy | ||
| "${QIF_SOURCE_BIN_PATH_B}" | ||
| "${QIF_OUT_BIN_PATH_B}" |
No description provided.