Skip to content

fix qif component#853

Merged
EndrII merged 2 commits into
mainfrom
fix_snap
Jun 9, 2026
Merged

fix qif component#853
EndrII merged 2 commits into
mainfrom
fix_snap

Conversation

@EndrII

@EndrII EndrII commented Jun 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@EndrII EndrII enabled auto-merge June 9, 2026 13:31

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates src/CQtDeployer/CMakeLists.txt to copy the installerbase executable from the Qt Installer Framework to the build directory. The review feedback recommends renaming the newly introduced variables with the ambiguous _B suffix to more descriptive names, such as QIF_SOURCE_BASE_PATH and QIF_OUT_BASE_PATH, to improve code readability and maintainability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +118 to +119
set(QIF_SOURCE_BIN_PATH_B "${IQTA_TOOLS}/QtInstallerFramework/${QIFW_VERSION}/bin/installerbase.exe")
set(QIF_OUT_BIN_PATH_B "${QIF_DESTINATION_PATH}/installerbase.exe")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The variable suffix _B is ambiguous and does not clearly indicate that it refers to installerbase. Consider renaming QIF_SOURCE_BIN_PATH_B and QIF_OUT_BIN_PATH_B to QIF_SOURCE_BASE_PATH and QIF_OUT_BASE_PATH (or QIF_SOURCE_INSTALLERBASE_PATH and QIF_OUT_INSTALLERBASE_PATH) to improve readability and maintainability.

            set(QIF_SOURCE_BASE_PATH "${IQTA_TOOLS}/QtInstallerFramework/${QIFW_VERSION}/bin/installerbase.exe")
            set(QIF_OUT_BASE_PATH "${QIF_DESTINATION_PATH}/installerbase.exe")

Comment on lines +125 to +126
set(QIF_SOURCE_BIN_PATH_B "${IQTA_TOOLS}/QtInstallerFramework/${QIFW_VERSION}/bin/installerbase")
set(QIF_OUT_BIN_PATH_B "${QIF_DESTINATION_PATH}/installerbase")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Rename QIF_SOURCE_BIN_PATH_B and QIF_OUT_BIN_PATH_B to QIF_SOURCE_BASE_PATH and QIF_OUT_BASE_PATH here as well to maintain consistency and clarity.

            set(QIF_SOURCE_BASE_PATH "${IQTA_TOOLS}/QtInstallerFramework/${QIFW_VERSION}/bin/installerbase")
            set(QIF_OUT_BASE_PATH "${QIF_DESTINATION_PATH}/installerbase")

Comment on lines +137 to +139
COMMAND ${CMAKE_COMMAND} -E copy
"${QIF_SOURCE_BIN_PATH_B}"
"${QIF_OUT_BIN_PATH_B}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Update the copy command to use the renamed variables QIF_SOURCE_BASE_PATH and QIF_OUT_BASE_PATH.

            COMMAND ${CMAKE_COMMAND} -E copy
                "${QIF_SOURCE_BASE_PATH}"
                "${QIF_OUT_BASE_PATH}"

@EndrII EndrII merged commit 67ee1ef into main Jun 9, 2026
3 checks passed
@EndrII EndrII deleted the fix_snap branch June 9, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant