Migration to GitHub actions by EndrII · Pull Request #844 · QuasarApp/CQtDeployer

EndrII · 2025-11-26T20:13:43Z

pzhlkj6612 · 2025-11-27T13:12:57Z

There has been so long since we talk about GitHub Actions. It was several years ago. Time flies.

Are you planning to keep GHA only, or both GHA and buildbot?

EndrII · 2025-11-27T13:15:55Z

@pzhlkj6612 hi, no - I will stop using buildbot after integration GitHub Actions.

pzhlkj6612 · 2025-11-27T13:17:48Z

Okay. The "buildbot/WindowsCMakeBuilder" guy stuck at "Waiting for status to be reported".

EndrII · 2025-11-27T13:20:00Z

Okay. The "buildbot/WindowsCMakeBuilder" guy stuck at "Waiting for status to be reported".

yes, i will stop them after merge this PR

EndrII · 2025-12-25T19:21:40Z

/gemini review

gemini-code-assist

Code Review

This pull request migrates the project's CI/CD to GitHub Actions. The changes include modifications to CMake build scripts to integrate with the GitHub Actions environment, removal of an old Python-based dependency fetching script, and a codebase-wide refactoring to replace a custom logging utility with standard Qt logging macros (qDebug, qWarning, etc.). The changes are generally good and improve the project's build process and code quality. I've pointed out a few areas for improvement: decoupling the build scripts from the CI provider, correcting a log level, and fixing a typo in a variable name.

gemini-code-assist · 2025-12-25T19:26:08Z

+if(DEFINED ENV{GITHUB_ENV})
+    file(APPEND $ENV{GITHUB_ENV} "CQT_DEPLOYER_VERSION=${CQT_DEPLOYER_VERSION}\n")
+    file(APPEND $ENV{GITHUB_ENV} "CMAKE_SYSTEM_NAME=${CMAKE_SYSTEM_NAME}\n")
+    file(APPEND $ENV{GITHUB_ENV} "CMAKE_SYSTEM_PROCESSOR=${CMAKE_SYSTEM_PROCESSOR}\n")
+    file(APPEND $ENV{GITHUB_ENV} "INSTALLER_SUFIX=${INSTALLER_SUFIX}\n")
+
+endif()


This block introduces a direct dependency on GitHub Actions by checking for ENV{GITHUB_ENV}. This couples your build script to a specific CI system. For better portability and separation of concerns, consider passing the necessary information from the CI environment to CMake via command-line arguments. For example, you could define a CMake variable like CI_EXPORT_FILE and set it in your GitHub Actions workflow: cmake -DCI_EXPORT_FILE=$GITHUB_ENV .... Then, your CMake script would check for if(CI_EXPORT_FILE). A similar pattern is used in src/CQtDeployer/CMakeLists.txt and should also be refactored.

gemini-code-assist · 2025-12-25T19:26:08Z

-    QuasarAppUtils::Params::log("Get the recursive dependencies of " + lib.fullPath(),
-                                       QuasarAppUtils::Debug);
+
+    qWarning() << "Get the recursive dependencies of " + lib.fullPath();


The log level for this message was changed from Debug to Warning. However, this message seems to be for debugging purposes, indicating the start of a recursive dependency scan for a library. Changing it to a warning might generate a lot of noise in the logs, as it will be printed for every library being scanned. It would be more appropriate to use qDebug() here.

qDebug() << "Get the recursive dependencies of " + lib.fullPath();

gemini-code-assist · 2025-12-25T19:26:08Z


 void Packing::setDistribution(const QList<iDistribution*> &packages) {
-  _packages = packages;
+  _pakages = packages;


There's a typo in the member variable name: _pakages should be _packages. This typo is present in this line and other places in this file, as well as in the declaration in packing.h. Please correct it for consistency and readability.

Suggested change

_pakages = packages;

_packages = packages;

EndrII · 2026-05-21T12:31:26Z

/gemini please make review of this pull request and make suggestion if you detect any issues.

gemini-code-assist

Code Review

This pull request updates copyright years to 2026 across the project and transitions the logging system from a custom utility to standard Qt logging macros (qDebug, qInfo, qWarning, qCritical). It also enhances CI/CD integration by exporting build variables to GITHUB_ENV and refactors QIFW binary handling to copy local tools instead of using a Python script. Review feedback highlights several critical issues, including a misspelled member variable (_pakages) in packing.cpp that will cause compilation errors, and a broken log message in configparser.cpp where a placeholder is not properly formatted. Additionally, several typos and grammatical errors were identified in the newly added log strings, and one instance was noted where a debug message was incorrectly elevated to a warning level.

gemini-code-assist · 2026-05-21T12:34:46Z

+        qInfo() << "The qmake was found in the RPATH variable. qmake : %0"
+                   " If you want to disable search qmake executable in RPATH variable,"
+                   " use the noCheckRPATH option";


The log message is missing the QString wrapper and the .arg(qmakeFromRPath) call. As a result, the %0 placeholder will be printed literally, and the path information will be lost in the output.

qInfo() << QString("The qmake was found in the RPATH variable. qmake : %0" " If you want to disable search qmake executable in RPATH variable," " use the noCheckRPATH option").arg(qmakeFromRPath);

gemini-code-assist · 2026-05-21T12:34:46Z

-    QuasarAppUtils::Params::log("Get the recursive dependencies of " + lib.fullPath(),
-                                       QuasarAppUtils::Debug);
+
+    qWarning() << "Get the recursive dependencies of " + lib.fullPath();


The log level was changed from Debug to qWarning(). This message appears to be a trace/progress message and should remain at the debug level to avoid cluttering the output with unnecessary warnings during normal operation.

qDebug() << "Get the recursive dependencies of " + lib.fullPath();

gemini-code-assist · 2026-05-21T12:34:46Z

+            qCritical() << QString("Failed parese list of option values, This option support only single leve list. "
+                                " Example: use -Option val1,val2,val3 ");


This log message contains several typos: 'parese' should be 'parse', and 'leve' should be 'level'. Additionally, 'support' should be 'supports' for correct grammar.

qCritical() << QString("Failed to parse list of option values. This option supports only a single level list. " " Example: use -Option val1,val2,val3 ");

gemini-code-assist · 2026-05-21T12:34:46Z

-                    QuasarAppUtils::Info);
+        qInfo() << "'snap connect cqtdeployer:system-backup :system-backup'" <<
+            "GUI: Open the gnome system setting >> Applications >> CQtDeployer. "
+            "in menu rights and permisions enable system-backup.";


Typo: 'permisions' should be 'permissions'.

"in menu rights and permissions enable system-backup.";

gemini-code-assist · 2026-05-21T12:34:46Z

+            qWarning() << QString("You try sets property for the not exits target."
+                                  " target: %0").arg(pair.value(0));


This warning message contains typos and grammatical errors: 'You try sets' should be 'You are trying to set', and 'not exits' should be 'non-existent'.

qWarning() << QString("You are trying to set a property for a non-existent target." " target: %0").arg(pair.value(0));

gemini-code-assist · 2026-05-21T12:34:46Z

-            QuasarAppUtils::Params::log("Show info is failed!",
-                                        QuasarAppUtils::Error);
+
+            qCritical() << "Show info is failed!";


Grammar: 'Show info is failed!' is awkward. 'Show info failed!' or 'Showing info failed!' is more idiomatic. This pattern repeats in several other log messages in this switch block.

qCritical() << "Show info failed!";

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>

EndrII added 11 commits November 26, 2025 21:11

test CDCI

15195d4

Merge branch 'main' into CDCI

dc659f3

download all qt

5d08d04

disable all qt module for build and deploy

9c1427a

update output dir

20b6ba9

fix qt package

7dca47c

disable tests

7499ca3

disable docs

74a3af2

fix syntax cmake error

9f98df0

syntax

b9dc960

fix build

b6caf7b

EndrII self-assigned this Nov 27, 2025

EndrII added the BuildSystem label Nov 27, 2025

EndrII added this to CQtDeployer Nov 27, 2025

EndrII moved this to In Progress in CQtDeployer Nov 27, 2025

EndrII added this to the v1.7 milestone Nov 27, 2025

EndrII mentioned this pull request Nov 27, 2025

CQtDeployer: 1.6.2320.097d82b Segmentation Fault due to "import" keyword in QML Object ids #842

Closed

EndrII changed the title ~~test CDCI~~ Migration to GitHub actions Nov 27, 2025

EndrII and others added 8 commits November 30, 2025 11:09

try to fix deploy qifw

7ea042c

fix path

f8e9518

fix typo

b503c18

get qifw path wrow env

2a1f6a1

more info

e42224b

move to new ubuntu

6f7d244

force disable parallel deploy and release

c823588

disable verbose log for deploy step

35b1aa7

EndrII added 11 commits November 30, 2025 12:18

added lxd to ubuntu builder

1d17590

disable LSD on windows

6fb3c7f

added snap secret

53a355b

fix deploy and release snap

9c2db83

fix path of QIF

d217bd2

try to fix snap base name

a99324a

fix snap path

e33ffcd

update submodules

cd555f2

update window qt depends

702b186

remove specific compiller name from windows build

0ac1644

added qt mingw

66238cd

gemini-code-assist Bot reviewed Dec 25, 2025

View reviewed changes

update sumbodules and copyright

1e478a5

gemini-code-assist Bot reviewed May 21, 2026

View reviewed changes

EndrII and others added 6 commits May 21, 2026 14:36

Apply suggestions from code review

bca7a34

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Andrei Yankovich <EndrIIMail@gmail.com>

disable tests by default

b4fb1d8

Merge branch 'CDCI' of github.com:QuasarApp/CQtDeployer into CDCI

f0269f7

pr triggers

f31d16d

fix build

73cd9c5

remove arm

710a6b3

EndrII merged commit cbb3ce6 into main Jun 7, 2026
3 checks passed

EndrII deleted the CDCI branch June 7, 2026 10:14

github-project-automation Bot moved this from In Progress to Done in CQtDeployer Jun 7, 2026

		qCritical() << QString("Failed parese list of option values, This option support only single leve list. "
		" Example: use -Option val1,val2,val3 ");

		qWarning() << QString("You try sets property for the not exits target."
		" target: %0").arg(pair.value(0));

Uh oh!

Uh oh!

Conversation

EndrII commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pzhlkj6612 commented Nov 27, 2025

Uh oh!

EndrII commented Nov 27, 2025

Uh oh!

pzhlkj6612 commented Nov 27, 2025

Uh oh!

EndrII commented Nov 27, 2025

Uh oh!

EndrII commented Dec 25, 2025

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Dec 25, 2025

Choose a reason for hiding this comment

Uh oh!

EndrII commented May 21, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

EndrII commented Nov 26, 2025 •

edited

Loading