Re-enable precompilation#286
Open
lkdvos wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #226.
The idea is that with the latest versions of Strided, it might be reasonable to just enable precompilation always, hopefully helping out with the CI runtimes in downstream packages like TensorKit and MPSKit.
I am not entirely sure if #208 is still happening, but I'd be willing to give it another try?
Additionally, I've slightly reorganized the
tensoradd/tensortracecode to reduce the total number of Strided kernels that have to be generated by canonicalizing the alpha and beta number types, and no longer specializing on unused backend or allocator arguments