Remove heretic for real - #180
Open
SeeroftheNight wants to merge 3 commits into
Open
Conversation
found the offender, this removes Heretic from the guidebook completely
github-actions
Bot
added
size/S
S: Needs Review
S: Untriaged
Changes: No C#
Changes: Port
labels
ok I commented out every line, this should prevent the errors that were occuring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Fixed the issue causing Heretic to still appear within the guidebook. This is a resubmit of my last pull request because it turned out I didn't actually fix it all the way, I just removed the initial "Heretic" guidebook entry without removing any of the following entries related to it.
Why / Balance
Heretic is not available on QB and was not supposed to be appearing in the guidebook. This fixes that.
Technical details
some lines had to be commented out in Resources/Prototypes/_Goobstation/Heretic/Guidebook/antagonist.yml
Media
Requirements
Licensing
Changelog