feat: add ISSUE_TEMPLATE config, ADR template, PR labeler, FUNDING.yml#12
Open
cryptoxdog wants to merge 1 commit into
Open
feat: add ISSUE_TEMPLATE config, ADR template, PR labeler, FUNDING.yml#12cryptoxdog wants to merge 1 commit into
cryptoxdog wants to merge 1 commit into
Conversation
- .github/ISSUE_TEMPLATE/config.yml: disable blank issues, add contact links - docs/adr/template.md + docs/adr/README.md: standard ADR template (MADR-style) - .github/labeler.yml + .github/workflows/labeler.yml: auto-label PRs by changed path, mirrors CODEOWNERS blast-radius mapping - FUNDING.yml: placeholder funding config (org has no public sponsor links yet, left as documented no-op)
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fills four confirmed gaps from the repo template/root-file audit:
.github/ISSUE_TEMPLATE/config.yml— disables blank issues, adds contact links for security reports, governance/CANONICAL_LAW questions, and the CI kernel API registry. Completes the existing 4-template issue form set (bug_report.yml,ci-failure.yml,feature_request.yml,gov-violation.yml).docs/adr/template.md+docs/adr/README.md— org-wide MADR-style Architecture Decision Record template. This repo hosts the template only; ADRs themselves are recorded per-consumer-repo under their owndocs/adr/. Explicitly scoped as decision history, distinct fromCANONICAL_LAW.md(current binding policy) — README documents the relationship and cross-linking convention (Superseded by ADR-NNNN)..github/labeler.yml+.github/workflows/labeler.yml— path-based PR auto-labeling viaactions/labeler@v5, mirroring the blast-radius path groups already defined inCODEOWNERS(workflow-templates/,l9-ci-pack/,ops/,.github/ISSUE_TEMPLATE/, health files,profile/, registry/ADRs). Usespull_request_targetwith minimalcontents: read/pull-requests: writepermissions — never checks out or executes PR branch code.FUNDING.yml— added as a documented no-op (all fields commented out) rather than omitted, since this looks like an internal/private org with no sponsor links today. Flipping it on later is a one-line change instead of a new file needing CODEOWNERS re-review.Why
Follow-up from a structural gap audit of this repo: every existing template (issue forms, PR template, health files, CODEOWNERS) was confirmed correctly placed for org-wide inheritance, but these four were missing or incomplete.
Placement rationale
ISSUE_TEMPLATE/config.ymlmust live at.github/ISSUE_TEMPLATE/config.yml— this is the only path GitHub reads for the issue-chooser config.docs/adr/rather than.github/since it's consumed by copying into other repos, not inherited automatically like health files or issue templates — GitHub has no ADR-inheritance mechanism, so this is documentation, not an org default.labeler.ymlfollows theactions/labelerconvention of living at.github/labeler.yml, referenced byconfiguration-pathin the new workflow.FUNDING.ymlmust live at repo root (or.github/) to render the sponsor button; placed at root alongside the other community health files.Best-practice notes
actions/labelerpinned to a full 40-char commit SHA (8558fd7...= v5.0.0), consistent with this repo's existing SHA-pin discipline (ops/audit-sha-pins.shper PR ci(dogfood): add actionlint, repo-wide SHA-pin audit, properties.json schema #10).pull_request_target(notpull_request) with the minimum required permission scopes, and does not execute any code from the PR branch.Not done in this PR
CODEOWNERSis not updated to add ownership rules for the new paths (docs/adr/,.github/labeler.yml) — left for a maintainer to decide ownership, since CODEOWNERS itself is a blast-radius file requiring @cryptoxdog review per its own rules.README.mdandCANONICAL_LAW.mdcross-repo reference gaps identified in the earlier audit are out of scope here — tracked separately.Test plan
actionlint(once PR ci(dogfood): add actionlint, repo-wide SHA-pin audit, properties.json schema #10 merges) should pass on.github/workflows/labeler.yml.ops/and confirm thearea:opslabel is applied.