Optimize shared-method serialization with method references - #717
Optimize shared-method serialization with method references#717zhenrongliew wants to merge 1 commit into
Conversation
…erializationModule
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
kaihsin
left a comment
There was a problem hiding this comment.
I like this, its more clean than previously. Notice that the change of how schema version is assigned will be super breaking. @david-pl @kylequera.
|
consider this is breaking change, Dennis, can you decouple the versioning change into another PR? |
83b6a8a to
5c0817d
Compare
Split into: #717 now contains only the method-reference payload change. Explicit codec versioning has moved to the stacked PR #720. Both PRs are breaking changes. |
|
Thanks I will remove the breaking from this PR then |
Summary
This is a breaking payload-representation change. Methods are now defined using identity-based IDs, repeated call sites use
method_ref, and the previoussymbol_table/mangled-method representation is removed.Payloads containing the old mangled method records are not supported by this decoder.
Explicit codec versioning and the policy for rejecting unversioned payloads are separated into the stacked follow-up PR #720
Motivation
Previously, every call site serialized and reconstructed the complete method wrapper, body already de-duplicated with
region_ref.On the representative shared-callee benchmark, relative to #713: