feat: add point spread function analysis#97
Open
aadarwal wants to merge 1 commit into
Open
Conversation
Add a reusable geometric PSF computation API over traced RayPath data, expose it through the raytracing controller, and add a Tools menu dialog for computing centroid, RMS radius, FWHM, and histogram metrics from the current rays. Also update the main-window smoke test to match the current Optiverse window title and clean up Qt timers explicitly. Co-Authored-By: Codex <noreply@openai.com>
aadarwal
force-pushed
the
feature/point-spread-functions
branch
from
2413279 to
b9d3dbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optiverse.raytracinggeometric PSF API over tracedRayPathdata.Addresses #17.
Test plan
uv run --extra dev mypy src/uv run --extra dev pytest tests/raytracing/test_psf.py tests/ui/test_point_spread_dialog.py tests/test_controllers.py tests/ui/test_main_window.py -quv run --extra dev pytest tests/raytracing -quv run --extra dev ruff check src/optiverse/raytracing/psf.py src/optiverse/raytracing/__init__.py src/optiverse/ui/controllers/raytracing_controller.py src/optiverse/ui/views/point_spread_dialog.py src/optiverse/ui/views/main_window.py src/optiverse/ui/builders/action_builder.py tests/raytracing/test_psf.py tests/ui/test_point_spread_dialog.py tests/ui/test_main_window.pyNotes
This is a geometric PSF for the current 2D raytracer. Diffraction PSF and 3D detector modeling remain separate future work.