Various Enhancements for CBC Vector Search - #616
Open
sou-cheng-choi wants to merge 15 commits into
Open
Conversation
* Min Python version * Pass Python version to environment * Pre-release tests * Get more info * Security Fix * requires-python = ">= 3.9" in pyproject.toml * Python 3.9 Compatibility * Fix versions * Fix windows test failures * Installs the missing l3backend MiKTeX package
* Update demo notebook initialization cells * Notebooks have been moved * Add Colab dependency install cells * Fix Colab notebook install cells * Fix spelling in Colab notebooks * Remove unused os import from Colab cells * Use capture for Colab install output * Automating Colab/notebook consistency * Update * Update makefile * Add make target for Colab bootstrap classification * Debugged `harden_colab_notebook.py` and add unit tests for badge handling * Add branch notebook execution script * Skip Colab bootstrap during branch notebook execution * Download Dakota Genz points in notebook * Remove Dakota Genz generation fallback * Use gdown for Dakota Genz data download * Add local notebook execution script * Comment out gdown in Dakota notebook * Fix Windows notebook CI LaTeX setup * Address Colab readiness review feedback * Reconcile Colab tooling with develop * Refresh safe Colab bootstrap cells * Preserve notebook serialization during hardening * Better Colab notebook handling: more dependencies support and improved smoke tests * Fix CodeQL check errors * Add title to notebook and update kernel name and version * Fix errors after manually testing in Google Colab * Fix problems after manually running in Google Colab * Minor enhancements * Fix colab error * Fix typo * Simplify Colab smoke tests: drop dead PR scoping, fix diagnostics * Add harden_colab_notebook to format target * Add tools to open in Colab (for developers) * Attempt to fix Colab errors * Correct Colab notebook manifest and build process * Fix unit test failure --------- Co-authored-by: sou-cheng-choi <sou.cheng.choi@stanfordalumni.org>
…l input to wssd method.
…ved warning for missing sympy. Better format.
sou-cheng-choi
requested review from
JiangruiKang,
algo-hawk and
larissensium
September 4, 2026 01:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main improvements in decreasing order of impact:
np.argminon WSSD scores with abest_index()helper, which finds the lowest index among scores withinrtol=1e-13of the minimum, ensuring consistency across platforms (ARM vs x86).expected_squared_periodic_discrepanciesfunction now uses O(n) memory. The dense frequency matrix (log₂ n_max, n_max) was replaced by a row-sum collapse. Memory usage drops significantly from ~12.5 GiB to ~1 GiB at n_max = 2²⁵, while maintaining algebraic exactness.kronecker_vector_search_mobius_transformwithd_max=1.Lattice.wssdmethod gains akernel=parameter that allows custom kernels to be accessed through the public method, forwarding them toexpected_squared_periodic_discrepancies.sample_weights(< n_maxvs!= n_max) inlattice.py, which changes the failure mode from a crypticnp.dotshape error to a clearValueError. TheMissing-sympy hint print()is now handled via a filterableUserWarning, reducing noise.k_constlist-comprehension withnp.arangefor efficiency. Also removed the unreferenced filekron_vector_d-100_N-2exp20_26_06_01.txtand its associated packaging line.mkdocs.yml.pyg_lib.developbranch.