fix: 8 bug fixes — sensor data loss, SSL bypass, JSON injection, ZeroDivisionError, and more#145

Merged

KJonline merged 29 commits into

devfrom

bug-analysis

Jun 20, 2026

Commits on May 23, 2026

Commits on May 24, 2026

Commits on May 25, 2026

fix: guard api_resp_d None before dict access; defend homes list against null

KJonline
and
claude
committed
fix: raise HiveApiError for unhandled Cognito ClientError codes

KJonline
and
claude
committed
fix: token_created not updated in elif-token branch; bare refreshToken access

KJonline
and
claude
committed
fix: close() must not close a caller-provided websession

KJonline
and
claude
committed
fix: use safe _get_product_state in get_mode BOOST path (heating + hotwater)

KJonline
and
claude
committed
fix: set_boost_off returns False instead of sending mode=None to API

KJonline
and
claude
committed
fix: return int brightness; return HS 2-tuple from get_color for HA hs_color

KJonline
and
claude
committed
fix: raise HiveUnknownConfiguration (not HiveReauthRequired) for empty device data

KJonline
and
claude
committed
fix: device registration wrong exceptions and unnecessary async methods

KJonline
and
claude
committed
fix: copy schedule slots in get_schedule_nnl to prevent mutation; guard hotwater schedule NNL

KJonline
and
claude
committed
fix: list→set for battery/mode, remove dead device_attributes code, fix Map.__delattr__

KJonline
and
claude
committed
test: cover remaining branch gaps in session/auth and session/polling

KJonline
and
claude
committed
refactor: remove deprecated refresh_tokens from HiveApi

KJonline
and
claude
committed
test: remove redundant tests from catch-all and relocate unique ones

KJonline
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: 8 bug fixes — sensor data loss, SSL bypass, JSON injection, ZeroDivisionError, and more#145

fix: 8 bug fixes — sensor data loss, SSL bypass, JSON injection, ZeroDivisionError, and more#145
KJonline merged 29 commits into
devfrom
bug-analysis

Commits on May 23, 2026

refactor: improve exception handling and code organization

fix: use device_id (not hive_id) to look up data.devices in sensor HIVE_TYPES branch

fix: guard against None from .get() before .split() in async_init and get_password_authentication_key

fix: catch ZeroDivisionError in colour-temperature conversion methods

fix: epoch_time to_epoch now honours the pattern argument instead of hardcoding it

Commits on May 24, 2026

fix: remove SSL verify=False and urllib3 warning suppression; use json.dumps in set_state

chore: remove unused POOL, deprecated refresh_tokens and its tests, and dead url/status guard

fix: add device context to bare _LOGGER.error(e) calls in get_mode and boost helpers

fix: updateInterval now sets config.scan_interval instead of silently returning True

fix: wrap updateInterval new_interval in timedelta(seconds=) to match SessionConfig type

Commits on May 25, 2026

fix: guard api_resp_d None before dict access; defend homes list against null

fix: raise HiveApiError for unhandled Cognito ClientError codes

fix: token_created not updated in elif-token branch; bare refreshToken access

fix: close() must not close a caller-provided websession

fix: use safe _get_product_state in get_mode BOOST path (heating + hotwater)

fix: set_boost_off returns False instead of sending mode=None to API

fix: return int brightness; return HS 2-tuple from get_color for HA hs_color

fix: raise HiveUnknownConfiguration (not HiveReauthRequired) for empty device data

fix: device registration wrong exceptions and unnecessary async methods

fix: copy schedule slots in get_schedule_nnl to prevent mutation; guard hotwater schedule NNL

fix: list→set for battery/mode, remove dead device_attributes code, fix Map.delattr

test: cover remaining branch gaps in session/auth and session/polling

refactor: remove deprecated refresh_tokens from HiveApi

test: remove redundant tests from catch-all and relocate unique ones

Commits on May 27, 2026

test: migrate all unique tests from catch-all into dedicated files

test: remove 3 duplicate tests from module files

refactor: eliminate _extended test files by renaming and merging

Commits on Jun 16, 2026

refactor: consolidate API error handling and remove deprecated code

refactor: remove unused _BOOST_MINS constant from test_hotwater.py