No std ThreadId

[Person-93]

Re-implement ThreadId using PyThread_get_thread_ident. This makes is usable in no_std context.

[clin1234]

lgtm

[davidhewitt]

Thanks, one comment on the FFI definition (see below).

Do you expect that the test suite (which does a lot of thread spawning) will need to change?

[Person-93]

Do you expect that the test suite (which does a lot of thread spawning) will need to change?

I don't think it will need to change, but it might be worth enabling it for wasm build and pulling in one of the wasm threading crates as a dev dependency.

[davidhewitt]

Thanks

[codspeed-hq]

Merging this PR will not alter performance

✅ 141 untouched benchmarks
⏩ 6 skipped benchmarks¹

---

_{Comparing Person-93:no_std_thread_id (5b9a18c) with main (a30ced8)}

Footnotes

1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[clin1234]

@codspeedbot explain why this is faster

[Person-93]

Should we exclude PyPy from no_std support?

[Person-93]

I don't think this will work for PyPy, that means we will need to use rust std's ThreadId when the std feature is enabled, so this is blocked on #6155

[davidhewitt]

I lost this thread, what made us conclude this doesn't work for PyPy?

[Person-93]

I lost this thread, what made us conclude this doesn't work for PyPy?

PyPy doesn't seem to have the function to get the thread id.

[davidhewitt]

It looks like it should be present:

https://github.com/pypy/pypy/blob/808488746c6abf3961a131eb9215b5073853e123/pypy/module/cpyext/include/pythread.h#L18

I'll try to figure out where it's going wrong and if needed report an issue upstream.