fix: canonicalize keywords and whitespaces - #66
Open
Snehil-Shah wants to merge 2 commits into
Open
Conversation
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Comment |
Snehil-Shah
commented
Aug 29, 2026
Author
There was a problem hiding this comment.
@renecannao I added a dedicated file as an AST-level regression suite for this. Let me know if you want it spread across existing files instead.
Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, many values are stored as spans of the input in the AST, which later produces a different digest for the same query written with different casing, spacing, or comments.
This PR stores the canonical spelling at parse time instead of deriving it from the input, with the parser writing its own separators rather than inheriting whatever sat between tokens. The result is stable ASTs and stable digests.
It also adds dialect-aware canonicalization for function names: MySQL resolves them case-insensitively (including backtick-quoted), while PostgreSQL folds only undelimited names, and folds them down.