Skip to content

ci: iterate JSON array root when extracting Claude review text #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loothero merged 2 commits into from
May 3, 2026
+40 −60
Merged

ci: iterate JSON array root when extracting Claude review text #146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc83c6c
ci: iterate the JSON array root when extracting Claude review text
loothero May 3, 2026
4b7c45a
ci: harden Claude review extraction against multi-line, error, and mi…
loothero May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 40 additions & 60 deletions .github/workflows/pr-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,19 +501,20 @@ jobs:
if: always()
env:
EXECUTION_FILE: ${{ steps.claude.outputs.execution_file }}
HEADING: "## Claude Review - Cairo/Starknet Contract Review"
run: |
: > /tmp/review.txt

if [ -z "$EXECUTION_FILE" ] || [ ! -f "$EXECUTION_FILE" ]; then
printf '%s\n\nNo review output was produced.\n' "$HEADING" > /tmp/review.txt
echo "::error::Claude action did not produce an execution file"
exit 1
fi

REVIEW=$(jq -r 'select(.type == "result") | .result // empty' "$EXECUTION_FILE" 2>/dev/null | tail -1)
REVIEW=$(jq -r '[.[] | select(.type == "result")] | last | .result // empty' "$EXECUTION_FILE" 2>/dev/null || true)
if [ -z "$REVIEW" ]; then
REVIEW=$(jq -r 'select(.type == "assistant") | .message.content[]? | select(.type == "text") | .text // empty' "$EXECUTION_FILE" 2>/dev/null)
REVIEW=$(jq -r '[.[] | select(.type == "assistant") | .message.content[]? | select(.type == "text") | .text] | join("\n\n")' "$EXECUTION_FILE" 2>/dev/null || true)
fi
if [ -z "$REVIEW" ]; then
printf '%s\n\nNo review output was produced.\n' "$HEADING" > /tmp/review.txt
echo "::error::Claude review produced no extractable output"
exit 1
fi
Expand All @@ -524,17 +525,11 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
run: |
{
echo "## Claude Review - Cairo/Starknet Contract Review"
echo ""
if [ -s /tmp/review.txt ]; then
cat /tmp/review.txt
else
echo "No review output was produced."
fi
} > /tmp/review-formatted.txt

gh pr comment ${{ github.event.pull_request.number }} --body-file /tmp/review-formatted.txt
if [ ! -s /tmp/review.txt ]; then
echo "review file is empty; skipping comment"
exit 0
fi
gh pr comment ${{ github.event.pull_request.number }} --body-file /tmp/review.txt

- name: Check for blocking findings
if: always()
Expand Down Expand Up @@ -745,19 +740,20 @@ jobs:
if: always()
env:
EXECUTION_FILE: ${{ steps.claude.outputs.execution_file }}
HEADING: "## Claude Review - React/Frontend Review"
run: |
: > /tmp/review.txt

if [ -z "$EXECUTION_FILE" ] || [ ! -f "$EXECUTION_FILE" ]; then
printf '%s\n\nNo review output was produced.\n' "$HEADING" > /tmp/review.txt
echo "::error::Claude action did not produce an execution file"
exit 1
fi

REVIEW=$(jq -r 'select(.type == "result") | .result // empty' "$EXECUTION_FILE" 2>/dev/null | tail -1)
REVIEW=$(jq -r '[.[] | select(.type == "result")] | last | .result // empty' "$EXECUTION_FILE" 2>/dev/null || true)
if [ -z "$REVIEW" ]; then
REVIEW=$(jq -r 'select(.type == "assistant") | .message.content[]? | select(.type == "text") | .text // empty' "$EXECUTION_FILE" 2>/dev/null)
REVIEW=$(jq -r '[.[] | select(.type == "assistant") | .message.content[]? | select(.type == "text") | .text] | join("\n\n")' "$EXECUTION_FILE" 2>/dev/null || true)
fi
if [ -z "$REVIEW" ]; then
printf '%s\n\nNo review output was produced.\n' "$HEADING" > /tmp/review.txt
echo "::error::Claude review produced no extractable output"
exit 1
fi
Expand All @@ -768,17 +764,11 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
run: |
{
echo "## Claude Review - React/Frontend Review"
echo ""
if [ -s /tmp/review.txt ]; then
cat /tmp/review.txt
else
echo "No review output was produced."
fi
} > /tmp/review-formatted.txt

gh pr comment ${{ github.event.pull_request.number }} --body-file /tmp/review-formatted.txt
if [ ! -s /tmp/review.txt ]; then
echo "review file is empty; skipping comment"
exit 0
fi
gh pr comment ${{ github.event.pull_request.number }} --body-file /tmp/review.txt

- name: Check for blocking findings
if: always()
Expand Down Expand Up @@ -989,19 +979,20 @@ jobs:
if: always()
env:
EXECUTION_FILE: ${{ steps.claude.outputs.execution_file }}
HEADING: "## Claude Review - Indexer/API Review"
run: |
: > /tmp/review.txt

if [ -z "$EXECUTION_FILE" ] || [ ! -f "$EXECUTION_FILE" ]; then
printf '%s\n\nNo review output was produced.\n' "$HEADING" > /tmp/review.txt
echo "::error::Claude action did not produce an execution file"
exit 1
fi

REVIEW=$(jq -r 'select(.type == "result") | .result // empty' "$EXECUTION_FILE" 2>/dev/null | tail -1)
REVIEW=$(jq -r '[.[] | select(.type == "result")] | last | .result // empty' "$EXECUTION_FILE" 2>/dev/null || true)
if [ -z "$REVIEW" ]; then
REVIEW=$(jq -r 'select(.type == "assistant") | .message.content[]? | select(.type == "text") | .text // empty' "$EXECUTION_FILE" 2>/dev/null)
REVIEW=$(jq -r '[.[] | select(.type == "assistant") | .message.content[]? | select(.type == "text") | .text] | join("\n\n")' "$EXECUTION_FILE" 2>/dev/null || true)
fi
if [ -z "$REVIEW" ]; then
printf '%s\n\nNo review output was produced.\n' "$HEADING" > /tmp/review.txt
echo "::error::Claude review produced no extractable output"
exit 1
fi
Expand All @@ -1012,17 +1003,11 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
run: |
{
echo "## Claude Review - Indexer/API Review"
echo ""
if [ -s /tmp/review.txt ]; then
cat /tmp/review.txt
else
echo "No review output was produced."
fi
} > /tmp/review-formatted.txt

gh pr comment ${{ github.event.pull_request.number }} --body-file /tmp/review-formatted.txt
if [ ! -s /tmp/review.txt ]; then
echo "review file is empty; skipping comment"
exit 0
fi
gh pr comment ${{ github.event.pull_request.number }} --body-file /tmp/review.txt

- name: Check for blocking findings
if: always()
Expand Down Expand Up @@ -1234,19 +1219,20 @@ jobs:
if: always()
env:
EXECUTION_FILE: ${{ steps.claude.outputs.execution_file }}
HEADING: "## Claude Review - General Engineering Review"
run: |
: > /tmp/review.txt

if [ -z "$EXECUTION_FILE" ] || [ ! -f "$EXECUTION_FILE" ]; then
printf '%s\n\nNo review output was produced.\n' "$HEADING" > /tmp/review.txt
echo "::error::Claude action did not produce an execution file"
exit 1
fi

REVIEW=$(jq -r 'select(.type == "result") | .result // empty' "$EXECUTION_FILE" 2>/dev/null | tail -1)
REVIEW=$(jq -r '[.[] | select(.type == "result")] | last | .result // empty' "$EXECUTION_FILE" 2>/dev/null || true)
if [ -z "$REVIEW" ]; then
REVIEW=$(jq -r 'select(.type == "assistant") | .message.content[]? | select(.type == "text") | .text // empty' "$EXECUTION_FILE" 2>/dev/null)
REVIEW=$(jq -r '[.[] | select(.type == "assistant") | .message.content[]? | select(.type == "text") | .text] | join("\n\n")' "$EXECUTION_FILE" 2>/dev/null || true)
fi
if [ -z "$REVIEW" ]; then
printf '%s\n\nNo review output was produced.\n' "$HEADING" > /tmp/review.txt
echo "::error::Claude review produced no extractable output"
exit 1
fi
Expand All @@ -1257,17 +1243,11 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
run: |
{
echo "## Claude Review - General Engineering Review"
echo ""
if [ -s /tmp/review.txt ]; then
cat /tmp/review.txt
else
echo "No review output was produced."
fi
} > /tmp/review-formatted.txt

gh pr comment ${{ github.event.pull_request.number }} --body-file /tmp/review-formatted.txt
if [ ! -s /tmp/review.txt ]; then
echo "review file is empty; skipping comment"
exit 0
fi
gh pr comment ${{ github.event.pull_request.number }} --body-file /tmp/review.txt

- name: Check for blocking findings
if: always()
Expand Down
Loading