Migration to Ant Design - #8
Open
markdstouffer wants to merge 9 commits into
Open
Conversation
cakoshakib
approved these changes
Apr 13, 2023
cakoshakib
left a comment
cakoshakib
left a comment
Contributor
There was a problem hiding this comment.
LGTM but stylistically I feel like the font feels a bit small now. Definitely a lot cleaner looking than before though!
| <RecoilRoot> | ||
| <RouterProvider router={router} /> | ||
| </RecoilRoot> | ||
| {/* <StyleProvider hashPriority="high"> */} |
| React.useEffect(() => { | ||
| if (showAddModal) { | ||
| const newTaskModal = modal.confirm({}); | ||
| newTaskModal.update({ |
Contributor
There was a problem hiding this comment.
I feel like this should probably be abstracted out of the actual Dashboard function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote most components to use the new component library
antd. Most work concentrated on changing the one existing modal (add task) - surprisingly using my own modal was easier! This should be more robust though.