Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/provider/viem-adapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ function createViemSigner(
}
return walletClient.signTypedData({
domain: {
chainId: Number(domain.chainId),
chainId: domain.chainId != null ? Number(domain.chainId) : undefined,
name: domain.name,
version: domain.version,
verifyingContract: domain.verifyingContract as `0x${string}`,
Expand Down
39 changes: 39 additions & 0 deletions test/provider/viem-adapter.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import { describe, expect, it, vi } from "vitest"
import { createViemWallet } from "../../src/provider/viem-adapter"

describe("createViemWallet", () => {
it("does not pass NaN when typed-data domain omits chainId", async () => {
const signTypedData = vi.fn().mockResolvedValue("0xsignature")
const wallet = createViemWallet({
publicClient: {
waitForTransactionReceipt: vi.fn(),
} as any,
walletClient: {
account: {
address: "0x0000000000000000000000000000000000000001",
},
signTypedData,
} as any,
})

if (!("signer" in wallet)) {
throw new Error("expected wallet signer")
}

await wallet.signer.signTypedData(
{
name: "OpenSea",
version: "1",
verifyingContract: "0x0000000000000000000000000000000000000002",
} as any,
{
Test: [{ name: "value", type: "string" }],
},
{ value: "hello" },
)

const call = signTypedData.mock.calls[0][0]
expect(call.domain.chainId).toBeUndefined()
expect(Number.isNaN(call.domain.chainId)).toBe(false)
})
})