Skip to content

Removed RemoveMarkupOrThrow in ChatSystem to allow invalid markdown from being set as chat messages #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuillTheCreature wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

Removed RemoveMarkupOrThrow in ChatSystem to allow invalid markdown from being set as chat messages #1336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Content.Server/Chat/Systems/ChatSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,8 +758,10 @@ private void SendEntitySpeak(
return;

// The Original Message [-] Einstein Engines - Language
var message = FormattedMessage.RemoveMarkupOrThrow(originalMessage); // Remove markup before transforming.
message = FormattedMessage.EscapeText(message); // Escape after removing markup
// Omu - RemoveMarkupOrThrow() ... throws an error when it's a invalid message, resulting in the message not appearing in chat.
// This could happen when for example someone sends a `[` or other things.
//var message = FormattedMessage.RemoveMarkupOrThrow(originalMessage); // Remove markup before transforming. Omu - Line commented out
var message = FormattedMessage.EscapeText(originalMessage); // Escape after removing markup. Omu - variable changed
message = TransformSpeech(source, message, language);

if (message.Length == 0)
Expand Down
Loading