fix(map): fit bounds to all returned routes#474
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the map “fit bounds” behavior so that when multiple routes (primary + alternatives) are returned, the viewport is fit to the combined geometry rather than only the selected route.
Changes:
- Add
src/route_zoom.jshelper to collect bounds coordinates across all available routes (with a fallback). - Update the
routeselectedhandler insrc/index.jsto compute bounds from all returned routes. - Add unit tests validating coordinate combination and fallback behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/index.js |
Uses combined route coordinates for L.latLngBounds() when fitting the map view. |
src/route_zoom.js |
Introduces getBoundsCoordinates() to aggregate coordinates across multiple routes. |
test/route_zoom.test.js |
Adds unit coverage for the new bounds-coordinate aggregation helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| sourceRoutes.forEach(function(route) { | ||
| if (route && Array.isArray(route.coordinates) && route.coordinates.length) { | ||
| coordinates = coordinates.concat(route.coordinates); |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com