[codex] ci: harden wasm SIMD gates

[Fieldnote-Echo]

Summary

• keep the pinned wasmtime install, and add clippy plus the aarch64-unknown-linux-gnu target to the wasm SIMD job
• lint ordvec's wasm simd128 and aarch64 NEON cfg-gated code under -D warnings
• preserve -D warnings in wasm build/test RUSTFLAGS
• make the wasmtime popcount test gate exact and assert the log reports exactly one passed test

Closes #20.

Validation

• cargo test --lib util::tests::popcount_helpers_match_naive -- --exact
• RUSTFLAGS='-D warnings -C target-feature=+simd128' cargo clippy -p ordvec --lib --target wasm32-unknown-unknown --no-deps -- -D warnings
• RUSTFLAGS='-D warnings' cargo clippy -p ordvec --lib --target aarch64-unknown-linux-gnu --no-deps -- -D warnings
• local pinned wasmtime v45.0.0 runtime check for util::tests::popcount_helpers_match_naive -- --exact, including the 1 passed grep
• pinned actionlint v1.7.12
• pinned zizmor --offline --persona=regular .github/workflows/

[gemini-code-assist]

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[qodo-code-review]

Review Summary by Qodo

Harden wasm SIMD CI gates with explicit linting

✨ Enhancement 🧪 Tests

Walkthroughs

Description

• Add clippy linting for wasm SIMD128 and aarch64 NEON targets
• Preserve -D warnings flag in wasm build and test RUSTFLAGS
• Make popcount test gate exact with single-test assertion
• Install aarch64-unknown-linux-gnu target and clippy component

Diagram

flowchart LR
  A["CI Toolchain Setup"] -->|"Add clippy + aarch64 target"| B["Enhanced Linting"]
  B -->|"Lint wasm32 + simd128"| C["Clippy wasm32"]
  B -->|"Lint aarch64 NEON"| D["Clippy aarch64"]
  E["RUSTFLAGS"] -->|"Add -D warnings"| F["Build & Test"]
  F -->|"Exact test gate"| G["Popcount Test Validation"]

Loading

File Changes

1. .github/workflows/ci.yml ✨ Enhancement +20/-8

Strengthen wasm SIMD CI with explicit linting gates

• Add clippy component and aarch64-unknown-linux-gnu target to rust-toolchain setup
• Insert two new clippy linting steps for wasm32 SIMD128 and aarch64 NEON targets with -D warnings
• Preserve -D warnings in RUSTFLAGS for wasm build and test jobs
• Replace generic popcount test with exact test path and add log validation to assert exactly one
 test passes

.github/workflows/ci.yml

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

[Copilot]

Pull request overview

Hardens the wasm SIMD CI lane by adding clippy lint coverage for both wasm32 simd128 and aarch64 NEON cfg-gated kernels under -D warnings, restoring -D warnings in the wasm build/test RUSTFLAGS overrides, and tightening the wasmtime popcount test so it can no longer silently pass when the filter matches zero tests.

Changes:

• Add clippy component and aarch64-unknown-linux-gnu target to the wasm job's Rust toolchain install, plus two new cargo clippy --no-deps steps targeting wasm32 (+simd128) and aarch64.
• Re-include -D warnings in the RUSTFLAGS env for the wasm build and wasmtime test steps.
• Run the wasmtime test with the fully-qualified path and --exact, tee the output, and assert test result: ok. 1 passed; so a rename can't silently produce a zero-test pass.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Fieldnote-Echo]

Bot review disposition:

• No inline review threads were opened on this PR.
• Gemini reported unsupported file types, so there was no actionable Gemini finding.
• Codecov reported all modified coverable lines covered.
• Qodo reported no material issues in the code-review pass; its summary-only walkthrough required no code change.
• Copilot provided an overview and generated no actionable inline comments.

No remediation or deferral issue needed.