Skip to content

ci: drop the macos-13 (Intel macOS) wheel leg - #78

Merged
Navi Bot (project-navi-bot) merged 1 commit into
mainfrom
ci/drop-macos13-wheel
May 26, 2026
Merged

ci: drop the macos-13 (Intel macOS) wheel leg#78
Navi Bot (project-navi-bot) merged 1 commit into
mainfrom
ci/drop-macos13-wheel

Conversation

@Fieldnote-Echo

Copy link
Copy Markdown
Member

Unblocks the PyPI release of ordvec 0.2.0.

Problem

The release-python.yml wheel matrix includes a macos-13 (Intel macOS) leg, but macos-13 hosted runners don't schedule for this repo — the job hangs queued indefinitely. build-wheels is a matrix job that publish depends on, so that one stuck leg blocks the whole PyPI release (the publish job is never reachable). The first release-python dispatch stalled on exactly this.

Fix

Drop the macos-13 leg. The matrix completes on its four available runners (linux x86_64 + aarch64, macOS arm64, windows x64). Intel-mac users install from the sdist (which compiles the extension from source); a cross-compiled Intel wheel is tracked in #29.

Context

  • The crate (ordvec 0.2.0) is already live on crates.io — that leg published fine.
  • After this merges and the new main HEAD goes green, re-dispatch release-python.yml to publish the wheel to PyPI, then approve the pypi environment.

The macos-13 hosted runner does not schedule for this repo, so the
`wheel x86_64 (macos-13)` job hangs `queued` indefinitely. `build-wheels` is a
matrix job that `publish` depends on, so that one stuck leg blocks the entire
PyPI release — the publish job is never reachable. The first release-python
dispatch stalled on exactly this.

Drop the Intel-macOS leg so the matrix completes on its four available runners
(linux x86_64 + aarch64, macOS arm64, windows x64). Intel-mac users install
from the sdist (it builds the extension from source); a cross-compiled Intel
wheel is tracked in #29.

Signed-off-by: Nelson Spence <nelson@projectnavi.ai>
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Remove macos-13 Intel macOS wheel from release CI matrix

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Remove macos-13 Intel wheel from CI matrix
• Unblocks PyPI release by eliminating queued job
• Adds explanatory comment about Intel wheel strategy
• Maintains four available runner configurations
Diagram
flowchart LR
  A["release-python.yml"] --> B["build-wheels matrix"]
  B --> C["macos-13 x86_64 removed"]
  C --> D["4 runners remain active"]
  D --> E["publish job unblocked"]

Loading

Grey Divider

File Changes

1. .github/workflows/release-python.yml ⚙️ Configuration changes +4/-1

Remove macos-13 Intel wheel from build matrix

• Removed macos-13 Intel macOS runner from wheel build matrix
• Added multi-line comment explaining removal rationale
• Clarifies that Intel-mac users install from sdist
• References issue #29 for cross-compiled Intel wheel tracking

.github/workflows/release-python.yml


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented May 26, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Context used

Grey Divider


Remediation recommended

1. Stale Intel wheel comment 🐞 Bug ⚙ Maintainability
Description
This PR removes the macOS x86_64 wheel leg from release-python.yml, but python.yml still claims an
Intel wheel is built and shipped by release-python.yml. That comment is now false and will mislead
future CI/release changes.
Code

.github/workflows/release-python.yml[R36-44]

Evidence
The release workflow matrix no longer includes a macOS x86_64 wheel build, while the binding CI
workflow still explicitly states that an Intel wheel is built and shipped by the release workflow.

.github/workflows/release-python.yml[36-44]
.github/workflows/python.yml[59-72]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`release-python.yml` no longer builds a macOS x86_64 (Intel) wheel, but `python.yml` still documents that the Intel wheel is “built + shipped by release-python.yml”. This is now incorrect and will confuse future maintainers.

### Issue Context
The release workflow matrix has removed the `macos-13`/x86_64 leg and added comments explaining that Intel users should install from the sdist (with a cross-compiled Intel wheel tracked separately).

### Fix Focus Areas
- .github/workflows/python.yml[59-72]
- .github/workflows/release-python.yml[36-44]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@project-navi-bot
Navi Bot (project-navi-bot) merged commit d2b2b10 into main May 26, 2026
25 checks passed
@project-navi-bot
Navi Bot (project-navi-bot) deleted the ci/drop-macos13-wheel branch May 26, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants