chore(deps): keep the numpy >=1.20 floor (decline the 2.x bump) - #51
Merged
Navi Bot (project-navi-bot) merged 1 commit intoMay 25, 2026
Merged
Conversation
ordvec-python is dep-light + abi3-py39, and rust-numpy 0.27 supports numpy 1.x AND 2.x at runtime, so we keep numpy >=1.20 for broad/legacy accessibility (Python 3.9 + numpy 1.x stacks). Raising the floor to >=2.0.2 (Dependabot #48) would drop those users — numpy 2.1+ also dropped Python 3.9 — for zero gain: ordvec's speed is its Rust SIMD kernels; numpy is only the zero-copy array container. Add an 'ignore' for numpy so Dependabot stops re-proposing the floor bump (maturin + security advisories still flow). Declines #48, closed manually with this rationale.
Nelson Spence (Fieldnote-Echo)
requested a review
from Navi Bot (project-navi-bot)
as a code owner
May 25, 2026 16:18
Review Summary by QodoConfigure Dependabot to ignore numpy floor version bumps
WalkthroughsDescription• Add Dependabot ignore rule for numpy to maintain >=1.20 floor • Preserve broad legacy compatibility for Python 3.9 + numpy 1.x stacks • Expand rationale comments explaining deliberate floor choice • Allow maturin and security updates to continue flowing Diagramflowchart LR
A["Dependabot pip config"] -->|add ignore rule| B["numpy dependency ignored"]
B -->|preserves floor| C["numpy >=1.20"]
C -->|maintains support| D["Python 3.9 + numpy 1.x"]
A -->|allows updates| E["maturin & security advisories"]
File Changes1. .github/dependabot.yml
|
project-navi-bot
approved these changes
May 25, 2026
There was a problem hiding this comment.
Code Review
This pull request updates the Dependabot configuration to ignore updates for the numpy dependency in the ordvec-python package. This change is intended to maintain a broad compatibility floor for legacy environments, specifically Python 3.9 and numpy 1.x, while leveraging the dual-version support of rust-numpy 0.27. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declines Dependabot #48 (numpy
>=1.20→>=2.0.2) and stops it re-proposing the floor bump.Why keep the broad floor:
&[f32]). numpy 2.0 improvements are to numpy own ops, which ordvec does not use.>=2.0.2floor would block the 3.9 + numpy-1.26 legacy long-tail for zero benefit. Broad accessibility on legacy systems is a deliberate virtue of a dep-light crate.Change: an
ignorefornumpyin the pip ecosystem ofdependabot.yml(rationale inline). maturin (build dep) bumps and security advisories still flow.