-
Notifications
You must be signed in to change notification settings - Fork 1
fix(ci): scope pip-audit to locked deps (was failing on transient runner pip CVE) #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Navi Bot (project-navi-bot)
merged 1 commit into
main
from
fix/pip-audit-scope-to-locked-deps
Apr 26, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -166,7 +166,14 @@ jobs: | |
| run: uv run bandit -r src/navi_bootstrap -ll | ||
|
|
||
| - name: Audit dependencies (pip-audit) | ||
| run: uvx pip-audit==2.9.0 | ||
| # Scope the audit to OUR locked dependency tree exported from uv, | ||
| # not the transient uvx environment. Otherwise pip-audit also scans | ||
| # its own runtime (which currently flags the runner's pip 26.0.1 | ||
| # for GHSA-58qw-9mgm-455v / CVE-2026-3219, an unpatched pip CVE | ||
| # that has nothing to do with this project's dependencies). | ||
| run: | | ||
| uv export --format requirements.txt --no-emit-project --no-hashes > /tmp/audit-deps.txt 2>/dev/null | ||
| uvx pip-audit==2.9.0 -r /tmp/audit-deps.txt | ||
|
Comment on lines
+169
to
+176
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1. Disallowed .github/ path modified This PR modifies .github/workflows/tests.yml, which is outside the allowed top-level directories (src/, tests/, packs/, docs/) and no explicit approval is recorded. This violates the directory allow-list policy for file modifications. Agent Prompt
|
||
|
|
||
| # ── Required check: quality-gate ──────────────────────────────────── | ||
| # CONTRACT: org ruleset requires this exact check name | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uv export ... 2>/dev/nullsuppresses all stderr, which will hide real export errors/warnings and make CI failures much harder to debug (you'll just see a downstream pip-audit failure). Prefer keeping stderr visible, or suppress only the known benign progress line (e.g., via a--quiet/--no-progressflag ifuv exportsupports it, or by filtering that specific line while still surfacing errors).