prevent crashes from some addons - #197
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a Stremio addon is installed, its manifest is fetched from the network, converted to AddonManifest (which contains a list of AddonResource objects), and persisted to disk. When the app restarts and loads those
saved addons, Gson deserializes the stored JSON back into AddonResource objects — and if the original manifest had no types field (some addons omit it), Gson sets types to null despite the Kotlin type saying List.
So it crashes specifically when:
An addon with a fully valid manifest (always includes "types": [...]) would never trigger it. It only hits users who installed certain addons that return incomplete manifests.