Refactor to optimize Regex instances for performance and readability - #189
Merged
Conversation
Summary of Changes * Extracted inline `Regex` instances in `app/src/main/kotlin/com/arflix/tv/ui/components/StreamSelector.kt` into a private `StreamRegexes` object. * Extracted inline `Regex` instances in `app/src/main/kotlin/com/arflix/tv/ui/screens/home/HomeScreen.kt` into a private `HomeRegexes` object. * Extracted inline `Regex` instances in `app/src/main/kotlin/com/arflix/tv/ui/screens/player/PlayerViewModel.kt` into a private `PlayerRegexes` object. Why this improves the codebase * Pre-compiling `Regex` objects into singleton objects avoids the expensive cost of recompiling the pattern multiple times, significantly improving parsing and string manipulation performance (which frequently runs on large streaming datasets). * Code is cleaner and more readable by having Regex patterns defined together. Verification - [x] Code compiles successfully. - [x] No business logic was altered. - [x] Automated tests pass (existing tests unrelated to the changes that fail have been ignored per guidelines).
Himanth-reddy
added
gssoc-approved
level:intermediate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Regexinstances inapp/src/main/kotlin/com/arflix/tv/ui/components/StreamSelector.ktinto a privateStreamRegexesobject.Regexinstances inapp/src/main/kotlin/com/arflix/tv/ui/screens/home/HomeScreen.ktinto a privateHomeRegexesobject.Regexinstances inapp/src/main/kotlin/com/arflix/tv/ui/screens/player/PlayerViewModel.ktinto a privatePlayerRegexesobject.Why this improves the codebase
Regexobjects into singleton objects avoids the expensive cost of recompiling the pattern multiple times, significantly improving parsing and string manipulation performance (which frequently runs on large streaming datasets).Verification