fix: normalize genre labels to proper case - #183
Merged
ProdigyV21 merged 2 commits intoMay 14, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Normalizes genre label display across the Details screen and Live TV UI by replacing all-uppercase rendering with a shared “proper case” formatter.
Changes:
- Added
formatGenreName(...)inMediaBadges.ktto title-case genre strings while preserving “TV”. - Updated Live TV search overlay and mini player to render genres via
formatGenreName. - Updated Details screen
GenreBadgeto render genres viaformatGenreName.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/kotlin/com/arflix/tv/util/MediaBadges.kt | Introduces shared genre formatting utility used by UI surfaces. |
| app/src/main/kotlin/com/arflix/tv/ui/screens/tv/live/SearchOverlay.kt | Switches genre label rendering from uppercase() to shared formatter. |
| app/src/main/kotlin/com/arflix/tv/ui/screens/tv/live/MiniPlayer.kt | Switches genre label rendering from uppercase() to shared formatter. |
| app/src/main/kotlin/com/arflix/tv/ui/screens/details/DetailsScreen.kt | Switches Details genre badge rendering from uppercase() to shared formatter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+31
to
+34
| if (trimmed.isEmpty()) return trimmed | ||
| val titled = trimmed.lowercase().replace(genreWordStartRegex) { match -> | ||
| match.groupValues[1] + match.groupValues[2].replaceFirstChar { it.titlecase() } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
Contributor
Author
|
@ProdigyV21 - I tested this and it didn't seem to fix the labels. It's still all caps before the Fantasy genre. Do you want me to close this PR or do you want to fix it? Probably just a minor change required. |
Owner
|
You can try to fix it yourself maybe? If you get stuck I can take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize genre labels to proper case across details and live TV surfaces by replacing uppercase rendering with a shared formatter.