Allow custom links handling#34
Open
roundedrectangle wants to merge 2 commits into
Open
Conversation
Member
|
I think this PR is missing the actual functionality, isn't it? It adds the setting and it renames the default function but it doesn't check for the setting when the function is called. openOrCopyUrl() shouldn't be renamed because it is public API and renaming would be a breaking change. |
Contributor
Author
|
Ok, you're right, it was indeed incomplete, thanks (I forgot to recheck everything before submitting the PR, sorry about that!). As for openOrCopyUrl(), making it a signal shouldn't break the API, as you can still call it like before, and with defaultLinkActions set to true (the default) it would behave the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed it isn't possible to add a custom link handler, this PR adds this functionality.