Log learning_rate to wandb during training#6
Merged
Conversation
Recreate the LR schedule in the training loop and log its value alongside the existing metrics, so the learning rate is visible in wandb without an external launcher patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
positronic/vendors/openpi/_launch.pyin Span OpenPI LR schedule across the full run via--lr-schedule.decay-stepspositronic#391).wandb.logpayload as the other metrics, at everylog_interval._launch.pyunnecessary. The other half (tyingdecay_stepsto run length) needs no openpi change:lr_scheduleis already CLI-exposed, so the caller can pass--lr-schedule.decay-steps=<num_train_steps>.Test plan
uvx ruff check scripts/train.pypasses.learning_rateappears in wandb with the expected warmup/cosine shape (cannot run here - training requires CUDA).