Skip to content

Update compiler flags and fix Makefile and source code - #411

Open
nater1983 wants to merge 3 commits into
Ponce:currentfrom
nater1983:current
Open

Update compiler flags and fix Makefile and source code#411
nater1983 wants to merge 3 commits into
Ponce:currentfrom
nater1983:current

Conversation

@nater1983

@nater1983 nater1983 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Added additional compiler flags and modified Makefile and source code for compatibility.

cc     -DSCOREFILE=\"/usr/games/lib/greed.hs\" -DRELEASE=\"4.2\" -o greed greed.c -lcurses
greed.c: In function ‘quit’:
greed.c:127:22: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘__sighandler_t’ {aka ‘void (*)(int)’} [-Wincompatible-pointer-types]
  127 |     void (*osig)() = signal(SIGINT, SIG_IGN);   /* save old signal */
      |                      ^~~~~~
In file included from greed.c:54:
/usr/include/signal.h:72:16: note: ‘__sighandler_t’ declared here
   72 | typedef void (*__sighandler_t) (int);
      |                ^~~~~~~~~~~~~~
greed.c:134:35: error: passing argument 2 of ‘signal’ from incompatible pointer type [-Wincompatible-pointer-types]
  134 |             (void) signal(SIGINT, osig);        /* reset old signal */
      |                                   ^~~~
      |                                   |
      |                                   void (*)(void)
/usr/include/signal.h:88:57: note: expected ‘__sighandler_t’ {aka ‘void (*)(int)’} but argument is of type ‘void (*)(void)’
   88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
      |                                          ~~~~~~~~~~~~~~~^~~~~~~~~
/usr/include/signal.h:72:16: note: ‘__sighandler_t’ declared here
   72 | typedef void (*__sighandler_t) (int);
      |                ^~~~~~~~~~~~~~
greed.c:135:36: error: passing argument 2 of ‘signal’ from incompatible pointer type [-Wincompatible-pointer-types]
  135 |             (void) signal(SIGQUIT, osig);
      |                                    ^~~~
      |                                    |
      |                                    void (*)(void)
/usr/include/signal.h:88:57: note: expected ‘__sighandler_t’ {aka ‘void (*)(int)’} but argument is of type ‘void (*)(void)’
   88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
      |                                          ~~~~~~~~~~~~~~~^~~~~~~~~
/usr/include/signal.h:72:16: note: ‘__sighandler_t’ declared here
   72 | typedef void (*__sighandler_t) (int);
      |                ^~~~~~~~~~~~~~
greed.c: In function ‘topscores’:
greed.c:521:18: error: conflicting types for ‘getenv’; have ‘char *(void)’
  521 |     extern char *getenv(), *tgetstr();
      |                  ^~~~~~
In file included from greed.c:48:
/usr/include/stdlib.h:773:14: note: previous declaration of ‘getenv’ with type ‘char *(const char *)’
  773 | extern char *getenv (const char *__name) __THROW __nonnull ((1)) __wur;
      |              ^~~~~~
greed.c:521:29: error: conflicting types for ‘tgetstr’; have ‘char *(void)’
  521 |     extern char *getenv(), *tgetstr();
      |                             ^~~~~~~
In file included from greed.c:53:
/usr/include/term.h:845:31: note: previous declaration of ‘tgetstr’ with type ‘char *(const char *, char **)’
  845 | extern NCURSES_EXPORT(char *) tgetstr (const char *, char **);
      |                               ^~~~~~~
greed.c:576:33: error: too many arguments to function ‘getenv’; expected 0, have 1
  576 |     if (new && tgetent(termbuf, getenv("TERM")) > 0) {
      |                                 ^~~~~~ ~~~~~~
greed.c:521:18: note: declared here
  521 |     extern char *getenv(), *tgetstr();
      |                  ^~~~~~
greed.c:578:18: error: too many arguments to function ‘tgetstr’; expected 0, have 2
  578 |         boldon = tgetstr("so", &tptr);
      |                  ^~~~~~~ ~~~~
greed.c:521:29: note: declared here
  521 |     extern char *getenv(), *tgetstr();
      |                             ^~~~~~~
greed.c:579:19: error: too many arguments to function ‘tgetstr’; expected 0, have 2
  579 |         boldoff = tgetstr("se", &tptr);
      |                   ^~~~~~~ ~~~~
greed.c:521:29: note: declared here
  521 |     extern char *getenv(), *tgetstr();
      |                             ^~~~~~~
make: *** [Makefile:10: greed] Error 1

Added additional compiler flags and modified Makefile and source code for compatibility.
@github-actions

Copy link
Copy Markdown

reverse dependencies - games/greed

None

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

✅ sbolint - games/greed ✅

greed: NOTE: greed.SlackBuild:64: LIBDIRSUFFIX gets set, but never used.
sbolint: greed checks out OK

Updated CMake policy setting from OLD to NEW and removed unused lines.
@github-actions

Copy link
Copy Markdown

reverse dependencies - games/hedgewars

None

@github-actions

Copy link
Copy Markdown

✅ sbolint - games/hedgewars ✅

sbolint: hedgewars checks out OK

@nater1983 nater1983 closed this Aug 10, 2026
@nater1983
nater1983 deleted the current branch August 10, 2026 04:10
@nater1983
nater1983 restored the current branch August 10, 2026 04:11
@nater1983 nater1983 reopened this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant