Skip to content

games/RetroArch: Update to version 1.22.2 enables building on current - #408

Closed
khronosschoty wants to merge 2 commits into
Ponce:RetroArchfrom
khronosschoty:RetroArch
Closed

games/RetroArch: Update to version 1.22.2 enables building on current#408
khronosschoty wants to merge 2 commits into
Ponce:RetroArchfrom
khronosschoty:RetroArch

Conversation

@khronosschoty

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

This PR contains too many changed packages (more than 10). Skipping normal PR checks.

@Ponce

Ponce commented Aug 7, 2026

Copy link
Copy Markdown
Owner

hi @khronosschoty !

this seems to still give me build errors with the newer ffmpeg...

sorry but what are the 15.0 specific patches are for?
you better send those to the RetroArch maintainer on SBo...

@khronosschoty

khronosschoty commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@Ponce Are you building with 1.22.2 sources tho ?

The patches for 15 were just to maintain reverse compatibility . Version 1.22.2 itself should resolve the ffmpeg build error

@Ponce

Ponce commented Aug 7, 2026

Copy link
Copy Markdown
Owner

yes, I'm building with this patch applied (and so with the version bump): this is where it breaks

CC record/drivers/record_ffmpeg.c
record/drivers/record_ffmpeg.c:229:66: error: no member named 'sample_fmts' in 'struct AVCodec'
  229 |    if (ffmpeg_codec_has_sample_format(AV_SAMPLE_FMT_FLTP, codec->sample_fmts))
      |                                                           ~~~~~  ^
record/drivers/record_ffmpeg.c:236:70: error: no member named 'sample_fmts' in 'struct AVCodec'
  236 |    else if (ffmpeg_codec_has_sample_format(AV_SAMPLE_FMT_FLT, codec->sample_fmts))
      |                                                               ~~~~~  ^
record/drivers/record_ffmpeg.c:243:71: error: no member named 'sample_fmts' in 'struct AVCodec'
  243 |    else if (ffmpeg_codec_has_sample_format(AV_SAMPLE_FMT_S16P, codec->sample_fmts))
      |                                                                ~~~~~  ^
record/drivers/record_ffmpeg.c:250:70: error: no member named 'sample_fmts' in 'struct AVCodec'
  250 |    else if (ffmpeg_codec_has_sample_format(AV_SAMPLE_FMT_S16, codec->sample_fmts))
      |                                                               ~~~~~  ^
record/drivers/record_ffmpeg.c:267:15: error: no member named 'supported_samplerates' in 'struct AVCodec'
  267 |    if (codec->supported_samplerates && !params->sample_rate)
      |        ~~~~~  ^
record/drivers/record_ffmpeg.c:273:31: error: no member named 'supported_samplerates' in 'struct AVCodec'
  273 |       int best_rate  = codec->supported_samplerates[0];
      |                        ~~~~~  ^
record/drivers/record_ffmpeg.c:276:26: error: no member named 'supported_samplerates' in 'struct AVCodec'
  276 |       for (i = 1; codec->supported_samplerates[i]; i++)
      |                   ~~~~~  ^
record/drivers/record_ffmpeg.c:279:36: error: no member named 'supported_samplerates' in 'struct AVCodec'
  279 |          int diff         = codec->supported_samplerates[i] - input_rate;
      |                             ~~~~~  ^
record/drivers/record_ffmpeg.c:288:32: error: no member named 'supported_samplerates' in 'struct AVCodec'
  288 |             best_rate = codec->supported_samplerates[i];
      |                         ~~~~~  ^
9 errors generated.
make: *** [Makefile:236: obj-unix/release/record/drivers/record_ffmpeg.o] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants