fix week alignment (should align to Monday, not Thursday)#2638
Open
ljeub-pometry wants to merge 1 commit into
Open
fix week alignment (should align to Monday, not Thursday)#2638ljeub-pometry wants to merge 1 commit into
ljeub-pometry wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 25921eb | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
4 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
4 ns/iter (± 0) |
1 ns/iter (± 0) |
4 |
lotr_graph/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph/iterate_exploded_edges |
605411 ns/iter (± 9440) |
285473 ns/iter (± 2920) |
2.12 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
8639428 ns/iter (± 64032) |
1564816 ns/iter (± 35303) |
5.52 |
lotr_graph_window_100/num_nodes |
14 ns/iter (± 0) |
5 ns/iter (± 0) |
2.80 |
lotr_graph_window_100/iterate_exploded_edges |
653454 ns/iter (± 5495) |
325242 ns/iter (± 847) |
2.01 |
lotr_graph_window_100_materialise/materialize |
8889930 ns/iter (± 52704) |
1669150 ns/iter (± 10700) |
5.33 |
lotr_graph_window_10/has_node_existing |
143 ns/iter (± 11) |
62 ns/iter (± 11) |
2.31 |
lotr_graph_window_10/iterate nodes |
29471 ns/iter (± 235) |
11339 ns/iter (± 40) |
2.60 |
lotr_graph_window_10/iterate_exploded_edges |
339589 ns/iter (± 4661) |
155788 ns/iter (± 1001) |
2.18 |
lotr_graph_window_10_materialise/materialize |
3714813 ns/iter (± 11354) |
971980 ns/iter (± 4278) |
3.82 |
lotr_graph_subgraph_10pc/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_subgraph_10pc_materialise/materialize |
2062547 ns/iter (± 12121) |
334634 ns/iter (± 1287) |
6.16 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
150 ns/iter (± 10) |
62 ns/iter (± 14) |
2.42 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
4965 ns/iter (± 84) |
1365 ns/iter (± 3) |
3.64 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1245586 ns/iter (± 10521) |
230399 ns/iter (± 2617) |
5.41 |
lotr_graph_window_50_layered/num_edges_temporal |
154360 ns/iter (± 4622) |
70121 ns/iter (± 7586) |
2.20 |
lotr_graph_window_50_layered/has_node_existing |
386 ns/iter (± 23) |
129 ns/iter (± 12) |
2.99 |
lotr_graph_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_window_50_layered/iterate nodes |
67789 ns/iter (± 508) |
19308 ns/iter (± 47) |
3.51 |
lotr_graph_window_50_layered/iterate edges |
189797 ns/iter (± 3029) |
83616 ns/iter (± 1318) |
2.27 |
lotr_graph_window_50_layered/graph_latest |
76987 ns/iter (± 1168) |
36649 ns/iter (± 916) |
2.10 |
lotr_graph_window_50_layered_materialise/materialize |
33157127 ns/iter (± 120788) |
3488825 ns/iter (± 24948) |
9.50 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
649471 ns/iter (± 5695) |
192686 ns/iter (± 1569) |
3.37 |
lotr_graph_persistent_window_50_layered/has_node_existing |
427 ns/iter (± 296) |
174 ns/iter (± 83) |
2.45 |
lotr_graph_persistent_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_persistent_window_50_layered/iterate nodes |
92169 ns/iter (± 492) |
35886 ns/iter (± 191) |
2.57 |
lotr_graph_persistent_window_50_layered/iterate edges |
183605 ns/iter (± 5194) |
84161 ns/iter (± 596) |
2.18 |
lotr_graph_persistent_window_50_layered/iterate_exploded_edges |
4640720 ns/iter (± 141461) |
1659940 ns/iter (± 19402) |
2.80 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
62671542 ns/iter (± 450688) |
5298035 ns/iter (± 147912) |
11.83 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
AlignmentUnit::Weeknow uses Monday as the start of the weekWhy are the changes needed?
1970-1-1 is a Thursday...
Does this PR introduce any user-facing change? If yes is this documented?
Fixes an alignment bug
How was this patch tested?
Added a prop test to verify the alignment