clean up the workflows so they should actually work on an external PR#2636
Merged
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: defdd18 | Previous: 9823ef7 | Ratio |
|---|---|---|---|
large/1k random edge additions |
1403046 ns/iter (± 126787) |
658628 ns/iter (± 51943) |
2.13 |
lotr_graph/num_edges |
4 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
4 ns/iter (± 0) |
1 ns/iter (± 0) |
4 |
lotr_graph/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph/iterate_exploded_edges |
598840 ns/iter (± 3591) |
285473 ns/iter (± 2920) |
2.10 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
8716660 ns/iter (± 175406) |
1564816 ns/iter (± 35303) |
5.57 |
lotr_graph_window_100/num_nodes |
14 ns/iter (± 0) |
5 ns/iter (± 0) |
2.80 |
lotr_graph_window_100_materialise/materialize |
8848619 ns/iter (± 22678) |
1669150 ns/iter (± 10700) |
5.30 |
lotr_graph_window_10/has_node_existing |
146 ns/iter (± 8) |
62 ns/iter (± 11) |
2.35 |
lotr_graph_window_10/iterate nodes |
30332 ns/iter (± 334) |
11339 ns/iter (± 40) |
2.68 |
lotr_graph_window_10/iterate_exploded_edges |
342581 ns/iter (± 3071) |
155788 ns/iter (± 1001) |
2.20 |
lotr_graph_window_10_materialise/materialize |
3736730 ns/iter (± 24074) |
971980 ns/iter (± 4278) |
3.84 |
lotr_graph_subgraph_10pc/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_subgraph_10pc_materialise/materialize |
2043437 ns/iter (± 14148) |
334634 ns/iter (± 1287) |
6.11 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
147 ns/iter (± 9) |
62 ns/iter (± 14) |
2.37 |
lotr_graph_subgraph_10pc_windowed/iterate nodes |
5101 ns/iter (± 122) |
1365 ns/iter (± 3) |
3.74 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1255090 ns/iter (± 9404) |
230399 ns/iter (± 2617) |
5.45 |
lotr_graph_window_50_layered/num_edges |
77459 ns/iter (± 3836) |
38714 ns/iter (± 1017) |
2.00 |
lotr_graph_window_50_layered/num_edges_temporal |
154812 ns/iter (± 1902) |
70121 ns/iter (± 7586) |
2.21 |
lotr_graph_window_50_layered/has_node_existing |
390 ns/iter (± 24) |
129 ns/iter (± 12) |
3.02 |
lotr_graph_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_window_50_layered/iterate nodes |
68451 ns/iter (± 472) |
19308 ns/iter (± 47) |
3.55 |
lotr_graph_window_50_layered/iterate edges |
186874 ns/iter (± 2161) |
83616 ns/iter (± 1318) |
2.23 |
lotr_graph_window_50_layered/graph_latest |
78227 ns/iter (± 1118) |
36649 ns/iter (± 916) |
2.13 |
lotr_graph_window_50_layered_materialise/materialize |
33128231 ns/iter (± 119070) |
3488825 ns/iter (± 24948) |
9.50 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
652399 ns/iter (± 8995) |
192686 ns/iter (± 1569) |
3.39 |
lotr_graph_persistent_window_50_layered/has_node_existing |
437 ns/iter (± 318) |
174 ns/iter (± 83) |
2.51 |
lotr_graph_persistent_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_persistent_window_50_layered/iterate nodes |
94352 ns/iter (± 770) |
35886 ns/iter (± 191) |
2.63 |
lotr_graph_persistent_window_50_layered/iterate edges |
178493 ns/iter (± 2941) |
84161 ns/iter (± 596) |
2.12 |
lotr_graph_persistent_window_50_layered/iterate_exploded_edges |
4638568 ns/iter (± 130525) |
1659940 ns/iter (± 19402) |
2.79 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
62168094 ns/iter (± 1095161) |
5298035 ns/iter (± 147912) |
11.73 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Clean up old private crud from the workflows
Why are the changes needed?
Workflows should be able to run against external PRs now as there are no more private submodules